dart2js: Forbid # placeholders in JS function bodies.

pkg/compiler/lib/src/diagnostics/messages.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 /**
  * The messages in this file should meet the following guide lines:
  *
  * 1. The message should be a complete sentence starting with an uppercase
  * letter, and ending with a period.
@@ skipping 263 matching lines @@
   INVALID_SYMBOL,
   INVALID_SYNC_MODIFIER,
   INVALID_TYPE_VARIABLE_BOUND,
   INVALID_UNNAMED_CONSTRUCTOR_NAME,
   INVALID_URI,
   INVALID_USE_OF_SUPER,
   JS_INTEROP_CLASS_CANNOT_EXTEND_DART_CLASS,
   JS_INTEROP_CLASS_NON_EXTERNAL_MEMBER,
   JS_OBJECT_LITERAL_CONSTRUCTOR_WITH_POSITIONAL_ARGUMENTS,
   JS_INTEROP_METHOD_WITH_NAMED_ARGUMENTS,
+  JS_PLACEHOLDER_CAPTURE,
   LIBRARY_NAME_MISMATCH,
   LIBRARY_NOT_FOUND,
   LIBRARY_NOT_SUPPORTED,
   LIBRARY_TAG_MUST_BE_FIRST,
   MAIN_NOT_A_FUNCTION,
   MAIN_WITH_EXTRA_PARAMETER,
   MALFORMED_STRING_LITERAL,
   MEMBER_NOT_FOUND,
   MEMBER_NOT_STATIC,
   MEMBER_USES_CLASS_NAME,
@@ skipping 2267 matching lines @@
           "Import of 'dart:mirrors'."),
 
       MessageKind.MIRROR_IMPORT_NO_USAGE:
         const MessageTemplate(MessageKind.MIRROR_IMPORT_NO_USAGE,
           "This import is not annotated with @MirrorsUsed, which may lead to "
           "unnecessarily large generated code.",
           howToFix:
               "Try adding '@MirrorsUsed(...)' as described at "
               "https://goo.gl/Akrrog."),
 
+      MessageKind.JS_PLACEHOLDER_CAPTURE:
+        const MessageTemplate(
+            MessageKind.JS_PLACEHOLDER_CAPTURE,
+            "JS code must not use '#' placeholders inside functions.",
+            howToFix:
+            "Use an immediately called JavaScript function to capture the"
+            " the placeholder values as JavaScript function parameters."),
+
       MessageKind.WRONG_ARGUMENT_FOR_JS_INTERCEPTOR_CONSTANT:
         const MessageTemplate(
           MessageKind.WRONG_ARGUMENT_FOR_JS_INTERCEPTOR_CONSTANT,
           "Argument for 'JS_INTERCEPTOR_CONSTANT' must be a type constant."),
 
       MessageKind.EXPECTED_IDENTIFIER_NOT_RESERVED_WORD:
         const MessageTemplate(MessageKind.EXPECTED_IDENTIFIER_NOT_RESERVED_WORD,
               "'#{keyword}' is a reserved word and can't be used here.",
               howToFix: "Try using a different name.",
               examples: const ["do() {} main() {}"]),
@@ skipping 1038 matching lines @@
   static String convertToString(value) {
     if (value is ErrorToken) {
       // Shouldn't happen.
       return value.assertionMessage;
     } else if (value is Token) {
       value = value.value;
     }
     return '$value';
   }
 }