Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2613)

Unified Diff: build/android/gyp/get_device_configuration.py

Issue 143623007: Fix an errant pylint change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/PRESUBMIT.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/get_device_configuration.py
diff --git a/build/android/gyp/get_device_configuration.py b/build/android/gyp/get_device_configuration.py
index 0a4893c2af7dd3afb0c2f637cff5f25c47c07683..ba4b5e88c14c4b815d5220e0ea696ecc66d9a2ad 100755
--- a/build/android/gyp/get_device_configuration.py
+++ b/build/android/gyp/get_device_configuration.py
@@ -11,6 +11,7 @@ install to and what needs to be installed to those devices.
"""
import optparse
+import os
import sys
# pylint: disable=F0401
@@ -18,6 +19,11 @@ from util import build_utils
from util import build_device
# pylint: disable=F0401
+BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..')
+sys.path.append(BUILD_ANDROID_DIR)
+
+from pylib import android_commands
frankf 2014/02/10 18:35:12 I'm guessing the original motivation here was for
jbudorick 2014/02/10 18:39:37 We could, but what's the point in only visibly dep
cjhopman 2014/02/10 18:50:47 Because getting the gyp dependencies correct is mu
+
def main(argv):
parser = optparse.OptionParser()
@@ -25,7 +31,7 @@ def main(argv):
parser.add_option('--output', action='store')
options, _ = parser.parse_args(argv)
- devices = build_device.GetAttachedDevices()
+ devices = android_commands.GetAttachedDevices()
device_configurations = []
for d in devices:
« no previous file with comments | « build/android/PRESUBMIT.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698