Remove USE(GSTREAMER) and USE(WEBAUDIO_GSTREAMER) guards.

Remove USE(GSTREAMER) and USE(WEBAUDIO_GSTREAMER) guards.

These are not used by blink.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148771

[lgombos, 2013-04-19 19:35:03]

Cleanup. It seems that most of the gstreamer-only files are already removed from
the tree.

[abarth-chromium, 2013-04-19 19:36:40]

lgtm

https://codereview.chromium.org/14362037/diff/1/Source/core/testing/Internals...
File Source/core/testing/Internals.cpp (left):

https://codereview.chromium.org/14362037/diff/1/Source/core/testing/Internals...
Source/core/testing/Internals.cpp:1951: void
Internals::simulateAudioInterruption(Node* node)
Should we remove this function (and any tests using it)?

[lgombos, 2013-04-19 19:50:16]

On 2013/04/19 19:36:40, abarth wrote:
> lgtm
> 
>
https://codereview.chromium.org/14362037/diff/1/Source/core/testing/Internals...
> File Source/core/testing/Internals.cpp (left):
> 
>
https://codereview.chromium.org/14362037/diff/1/Source/core/testing/Internals...
> Source/core/testing/Internals.cpp:1951: void
> Internals::simulateAudioInterruption(Node* node)
> Should we remove this function (and any tests using it)?

This function seems to be testing a use-case that could potentially be useful
for blink as well - just not implemented yet.  

https://bugs.webkit.org/show_bug.cgi?id=91611#c7

We can of course just as well reintroduce it when implemented. I am ok either
way.

[abarth-chromium, 2013-04-19 19:55:29]

I'd recommend removing the test and filing a bug referring to this CL.  That way
there's a breadcrumb trail someone can follow if/when we implement that feature.

[lgombos, 2013-04-19 20:23:39]

Removed Internals::simulateAudioInterruption (and the one related test).

Filed issue https://code.google.com/p/chromium/issues/detail?id=233719 .

[abarth-chromium, 2013-04-19 20:25:00]

Thanks!  LGTM

[commit-bot: I haz the power, 2013-04-19 23:03:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14362037/4001

[commit-bot: I haz the power, 2013-04-20 02:32:11]

Change committed as 148771

[Chris Rogers, 2013-04-23 19:35:42]

Please be *very* careful with changes like this which affect Web Audio - I need
to review these.

It turns out that the code removal in HRTFElevation.cpp was not a good idea
since all the other WebKit ports were using a more highly optimized loading
scheme for the HRTF database assets which we could benefit from.

It turns out that Raymond Toy is working on optimizing Android and just was
about to enable this code only to find it missing.

[lgombos, 2013-04-23 20:30:32]

On 2013/04/23 19:35:42, Chris Rogers wrote:
> Please be *very* careful with changes like this which affect Web Audio - I
need to review these.
> 
> It turns out that the code removal in HRTFElevation.cpp was not a good idea..

Chris, sorry for the trouble. I will know next time to add you as a reviewer for
this area. As for this incident, I assume Raymond will restore part of the CL
that he needs in HRTFElevation.cpp (and remove the part that is no longer
needed).

[eseidel, 2013-04-24 08:16:13]

I would recommend adding more watchlists for platform/audio:
http://src.chromium.org/viewvc/blink/trunk/WATCHLISTS?revision=148772