Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: trunk/src/chrome/browser/first_run/first_run.h

Issue 14362030: Revert 193513 "Add a short delay before showing the first run bu..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/browser/first_run/first_run.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/first_run/first_run.h
===================================================================
--- trunk/src/chrome/browser/first_run/first_run.h (revision 195175)
+++ trunk/src/chrome/browser/first_run/first_run.h (working copy)
@@ -12,13 +12,10 @@
#include "base/compiler_specific.h"
#include "base/gtest_prod_util.h"
#include "base/memory/ref_counted.h"
-#include "base/memory/weak_ptr.h"
-#include "chrome/browser/ui/browser_list_observer.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "ui/gfx/native_widget_types.h"
-class Browser;
class CommandLine;
class GURL;
class PrefRegistrySyncable;
@@ -187,10 +184,7 @@
// Show the first run search engine bubble at the first appropriate opportunity.
// This bubble may be delayed by other UI, like global errors and sync promos.
-class FirstRunBubbleLauncher
- : public content::NotificationObserver,
- public chrome::BrowserListObserver,
- public base::SupportsWeakPtr<FirstRunBubbleLauncher> {
+class FirstRunBubbleLauncher : public content::NotificationObserver {
public:
// Show the bubble at the first appropriate opportunity. This function
// instantiates a FirstRunBubbleLauncher, which manages its own lifetime.
@@ -205,13 +199,7 @@
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
- // chrome::BrowserListObserver override:
- virtual void OnBrowserRemoved(Browser* browser) OVERRIDE;
-
- void DoShowFirstRunBubble();
-
content::NotificationRegistrar registrar_;
- Browser* browser_;
DISALLOW_COPY_AND_ASSIGN(FirstRunBubbleLauncher);
};
« no previous file with comments | « no previous file | trunk/src/chrome/browser/first_run/first_run.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698