Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: trunk/src/chrome/browser/ui/browser.h

Issue 14362028: Speculative Revert 195108 "Changes to closing contents with beforeunload/unl..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/ui/browser.h
===================================================================
--- trunk/src/chrome/browser/ui/browser.h (revision 195133)
+++ trunk/src/chrome/browser/ui/browser.h (working copy)
@@ -290,22 +290,12 @@
// Gives beforeunload handlers the chance to cancel the close.
bool ShouldCloseWindow();
- // Figure out if there are tabs that have beforeunload handlers.
- // It starts beforeunload/unload processing as a side-effect.
- bool TabsNeedBeforeUnloadFired();
-
- // Returns true if all tabs' beforeunload/unload events have fired.
- bool HasCompletedUnloadProcessing() const;
-
bool IsAttemptingToCloseBrowser() const;
// Invoked when the window containing us is closing. Performs the necessary
// cleanup.
void OnWindowClosing();
- // Called when all unload processing completes so the browser can close.
- void OnUnloadProcessingCompleted();
-
// OnWindowActivationChanged handling ///////////////////////////////////////
// Invoked when the window containing us is activated.
@@ -442,6 +432,9 @@
content::WebContents* source,
const content::NativeWebKeyboardEvent& event) OVERRIDE;
+ // Figure out if there are tabs that have beforeunload handlers.
+ bool TabsNeedBeforeUnloadFired();
+
bool is_type_tabbed() const { return type_ == TYPE_TABBED; }
bool is_type_popup() const { return type_ == TYPE_POPUP; }
« no previous file with comments | « no previous file | trunk/src/chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698