Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: trunk/src/chrome/browser/ui/browser.cc

Issue 14362028: Speculative Revert 195108 "Changes to closing contents with beforeunload/unl..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/browser.cc
===================================================================
--- trunk/src/chrome/browser/ui/browser.cc (revision 195133)
+++ trunk/src/chrome/browser/ui/browser.cc (working copy)
@@ -599,14 +599,6 @@
return unload_controller_->ShouldCloseWindow();
}
-bool Browser::TabsNeedBeforeUnloadFired() {
- return unload_controller_->TabsNeedBeforeUnloadFired();
-}
-
-bool Browser::HasCompletedUnloadProcessing() const {
- return unload_controller_->HasCompletedUnloadProcessing();
-}
-
bool Browser::IsAttemptingToCloseBrowser() const {
return unload_controller_->is_attempting_to_close_browser();
}
@@ -648,11 +640,8 @@
chrome::NOTIFICATION_BROWSER_CLOSING,
content::Source<Browser>(this),
content::NotificationService::NoDetails());
-}
-void Browser::OnUnloadProcessingCompleted() {
- MessageLoop::current()->PostTask(
- FROM_HERE, base::Bind(&Browser::CloseFrame, weak_factory_.GetWeakPtr()));
+ tab_strip_model_->CloseAllTabs();
}
void Browser::OnWindowActivated() {
@@ -1203,6 +1192,10 @@
window()->HandleKeyboardEvent(event);
}
+bool Browser::TabsNeedBeforeUnloadFired() {
+ return unload_controller_->TabsNeedBeforeUnloadFired();
+}
+
bool Browser::IsMouseLocked() const {
return fullscreen_controller_->IsMouseLocked();
}
« no previous file with comments | « trunk/src/chrome/browser/ui/browser.h ('k') | trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698