Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 14362023: Replace math.h with cmath (Closed)

Created:
7 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 8 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Replace math.h with cmath This will make it easier to use other STL headers in the future Committed: http://code.google.com/p/v8/source/detail?r=14352

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Patch Set 5 : updates #

Total comments: 4

Patch Set 6 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -75 lines) Patch
M src/api.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M src/assembler.cc View 1 2 3 4 5 4 chunks +8 lines, -5 lines 0 comments Download
M src/ast.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/bignum-dtoa.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/cached-powers.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/conversions.cc View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M src/conversions-inl.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/dtoa.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/fixed-dtoa.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M src/ic.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/json-stringifier.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects-debug.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/platform-cygwin.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/platform-freebsd.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/platform-linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/platform-macos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/platform-openbsd.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/platform-posix.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/platform-solaris.cc View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M src/platform-win32.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/preparser.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M src/runtime.cc View 1 2 3 8 chunks +15 lines, -9 lines 0 comments Download
M src/strtod.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/win32-math.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M src/win32-math.cc View 1 2 3 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
plz review I checked that it builds on win, linux, and android. I don't have ...
7 years, 8 months ago (2013-04-19 10:33:44 UTC) #1
danno
generally looks ok, but a comment and question. https://codereview.chromium.org/14362023/diff/8001/src/assembler.cc File src/assembler.cc (right): https://codereview.chromium.org/14362023/diff/8001/src/assembler.cc#newcode1510 src/assembler.cc:1510: return ...
7 years, 8 months ago (2013-04-19 13:08:33 UTC) #2
jochen (gone - plz use gerrit)
https://chromiumcodereview.appspot.com/14362023/diff/8001/src/assembler.cc File src/assembler.cc (right): https://chromiumcodereview.appspot.com/14362023/diff/8001/src/assembler.cc#newcode1510 src/assembler.cc:1510: return OS::nan_value(); On 2013/04/19 13:08:33, danno wrote: > Please ...
7 years, 8 months ago (2013-04-19 13:12:25 UTC) #3
danno
lgtm, I'll land this for you
7 years, 8 months ago (2013-04-19 13:23:29 UTC) #4
danno
7 years, 8 months ago (2013-04-19 13:27:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 manually as r14352 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698