Source/bindings/v8/V8DOMWindowShell.cpp - Issue 14362015: WIP enum / V8PerContextData solution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8DOMWindowShell.cpp

Issue 14362015: WIP enum / V8PerContextData solution (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Crash during GC Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8DOMWindowShell.cpp

diff --git a/Source/bindings/v8/V8DOMWindowShell.cpp b/Source/bindings/v8/V8DOMWindowShell.cpp

index 439adc3c077fc4734f80766f8db2a52236230cdd..047ca882525850732bb9fd135b627fd6dadaafb4 100644

--- a/Source/bindings/v8/V8DOMWindowShell.cpp

+++ b/Source/bindings/v8/V8DOMWindowShell.cpp

@@ -78,7 +78,7 @@ static void checkDocumentWrapper(v8::Handle<v8::Object> wrapper, Document* docum

static void setInjectedScriptContextDebugId(v8::Handle<v8::Context> targetContext, int debugId)

{

- V8PerContextDebugData::setContextDebugData(targetContext, "injected", debugId);

+ V8PerContextDebugData::setDebugDataForContentScript(targetContext, debugId);

johnjbarton 2013/04/23 18:03:48 This will crash because the V8PerContextData objec

}

PassOwnPtr<V8DOMWindowShell> V8DOMWindowShell::create(Frame* frame, PassRefPtr<DOMWrapperWorld> world, v8::Isolate* isolate)