WIP enum / V8PerContextData solution

Source/bindings/v8/V8PerContextData.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 121 matching lines @@
             prototypeObject->SetAlignedPointerInInternalField(v8PrototypeTypeIndex, type);
         type->installPerContextPrototypeProperties(prototypeObject, m_context->GetIsolate());
         if (type->wrapperTypePrototype == WrapperTypeErrorPrototype)
             prototypeObject->SetPrototype(m_errorPrototype.get());
     }
 
     m_constructorMap.set(type, v8::Persistent<v8::Function>::New(m_context->GetIsolate(), function));
 
     return function;
 }
-static v8::Handle<v8::Value> createDebugData(const char* worldName, int debugId) 
+
+void V8PerContextDebugData::setDebugData(
+    v8::Handle<v8::Context> context, 
+    CompilationOriginCategory originCategory, 
+    CompilationContextCategory contextCategory, 
+    CompilationRestrictions restrictions,
+    int debugId) 
 {
-    char buffer[32];
-    unsigned wanted;
-    if (debugId == -1)
-        wanted = snprintf(buffer, sizeof(buffer), "%s", worldName);
-    else 
-        wanted = snprintf(buffer, sizeof(buffer), "%s,%d", worldName, debugId);
-
-    if (wanted < sizeof(buffer))
-        return v8::String::NewSymbol(buffer);
-
-    return v8::Undefined();
-};
-
-static v8::Handle<v8::Value> debugData(v8::Handle<v8::Context> context)
-{
-    v8::Context::Scope contextScope(context);
-    return context->GetEmbedderData(v8ContextDebugIdIndex);
+    v8::HandleScope scope;
+    V8PerContextData* data = V8PerContextData::from(context);
+    ASSERT(debugId);
+    
+    data->m_originCategory = originCategory;
+    data->m_contextCategory = contextCategory;
+    data->m_restrictions = restrictions;
+    data->m_debugId = debugId;
 }
 
-static void setDebugData(v8::Handle<v8::Context> context, v8::Handle<v8::Value> value)
+void V8PerContextDebugData::setDebugDataForPage(v8::Handle<v8::Context> context, int debugId) 
 {
-    v8::Context::Scope contextScope(context);
-    context->SetEmbedderData(v8ContextDebugIdIndex, value);
+    setDebugData(
+        context, 
+        CompilationOriginWeb, 
+        CompilationContextWebPage, 
+        CompilationRestrictionsNone,
+        debugId
+    );
 }
 
-bool V8PerContextDebugData::setContextDebugData(v8::Handle<v8::Context> context, const char* worldName, int debugId) 
+void V8PerContextDebugData::setDebugDataForContentScript(v8::Handle<v8::Context> context, int debugId) 
 {
-    if (!debugData(context)->IsUndefined())
-        return false;
-    v8::HandleScope scope;
-    v8::Handle<v8::Value> debugData = createDebugData(worldName, debugId);
-    setDebugData(context, debugData);
-    return true;
+    setDebugData(
+        context, 
+        CompilationOriginExtension, 
+        CompilationContextContentScript, 
+        CompilationRestrictionsNone,
+        debugId
+    );
 }
 
-int V8PerContextDebugData::contextDebugId(v8::Handle<v8::Context> context) 
+void V8PerContextDebugData::setDebugDataForSystemUtility(v8::Handle<v8::Context> context) 
+{
+    setDebugData(
+        context, 
+        CompilationOriginSystem, 
+        CompilationContextUtility, 
+        CompilationRestrictionsNone,
+        -1
+    );
+}
+
+int V8PerContextDebugData::debugId(v8::Handle<v8::Context> context) 
 {
     v8::HandleScope scope;
-    v8::Handle<v8::Value> data = debugData(context);
+    V8PerContextData* data = V8PerContextData::from(context);
+    return data->m_debugId; 
+}
 
-    if (!data->IsString())
-        return -1;
-    v8::String::AsciiValue ascii(data);
-    char* comma = strnstr(*ascii, ",", ascii.length());
-    if (!comma)
-        return -1;
-    return atoi(comma + 1);
+CompilationOriginCategory V8PerContextDebugData::compilationOriginCategory(v8::Handle<v8::Context> context) 
+{
+    v8::HandleScope scope;
+    V8PerContextData* data = V8PerContextData::from(context);
+    return data->m_originCategory; 
+}
+
+CompilationContextCategory V8PerContextDebugData::compilationContextCategory(v8::Handle<v8::Context> context) 
+{
+    v8::HandleScope scope;
+    V8PerContextData* data = V8PerContextData::from(context);
+    return data->m_contextCategory; 
+}
+
+CompilationRestrictions V8PerContextDebugData::compilationRestrictions(v8::Handle<v8::Context> context) 
+{
+    v8::HandleScope scope;
+    V8PerContextData* data = V8PerContextData::from(context);
+    return data->m_restrictions; 
+}
+
+static CompilationOriginCategory commonOriginCategory[] = {CompilationOriginDevtools, CompilationOriginDevtools, CompilationOriginSystem};
+static CompilationContextCategory commonContextCategory[] = {CompilationContextWebPage, CompilationContextWebPage, CompilationContextWebPage};
+static CompilationRestrictions commonRestrictions[] = {CompilationRestrictionsNone, CompilationRestrictionsOneFunction, CompilationRestrictionsNone};
+
+V8ScopedCompilation::V8ScopedCompilation(v8::Handle<v8::Context> context, ScopedCompilationCategory combo) 
+    : m_context(context) 
+{
+    init(commonOriginCategory[combo], commonContextCategory[combo], commonRestrictions[combo]);
+}
+
+V8ScopedCompilation::V8ScopedCompilation(v8::Handle<v8::Context> context, CompilationOriginCategory originCategory, CompilationContextCategory contextCategory, CompilationRestrictions restrictions)
+    : m_context(context)
+{
+    init(originCategory, contextCategory, restrictions);
+}
+
+void V8ScopedCompilation::init(CompilationOriginCategory originCategory, CompilationContextCategory contextCategory, CompilationRestrictions restrictions)
+{
+    V8PerContextData* data = V8PerContextData::from(m_context);
+    m_originCategory = data->m_originCategory;
+    m_contextCategory = data->m_contextCategory;
+    m_restrictions = data->m_restrictions;
+    m_debugId = data->m_debugId;
+    V8PerContextDebugData::setDebugData(m_context, originCategory, contextCategory, restrictions, m_debugId);
+}
+
+V8ScopedCompilation::~V8ScopedCompilation()
+{
+    ASSERT(!m_debugId);
+    v8::HandleScope scope;
+    V8PerContextDebugData::setDebugData(m_context, m_originCategory, m_contextCategory, m_restrictions, m_debugId);
+    m_debugId = 0;
 }
 
 } // namespace WebCore