Added new notification close icon image for Windows.

Added new notification close icon image for Windows.

This adds just the files. The code to use these files will be added
separately in a change list that can be delivered through the commit
queue (change lists with binary files like the ones in this chane cannot
use the commit queue).

This also adds some notification_expand*.png files which are renamed
versions of existing notifications_expand*.png files. This is the first
step in renaming those files. The second step, to be delivered in a
follow-up change list, will switch the code to use the new names. A
third step, coming in a third change list, will remove the versions of
the file with the old name.

BUG=232963
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195341

[oshima, 2013-04-19 20:03:17]

On 2013/04/19 19:40:34, dharcourt wrote:

I believe these are for both chromeos and windows?

[dharcourt, 2013-04-19 21:32:14]

On 2013/04/19 20:03:17, oshima wrote:
> On 2013/04/19 19:40:34, dharcourt wrote:
> 
> I believe these are for both chromeos and windows?

notification_close_windows*.png is for Windows only. There already are
inotification_close*.png files that are for ChromeOS (and perhaps other
platforms when we support those).

notification_expand*.png is for Windows and Chrome OS. It's just a rename of the
existing notifications_expand*.png (the naming scheme of the originals was
inconsistent with the other resource files).

[oshima, 2013-04-19 22:26:58]

On 2013/04/19 21:32:14, dharcourt wrote:
> On 2013/04/19 20:03:17, oshima wrote:
> > On 2013/04/19 19:40:34, dharcourt wrote:
> > 
> > I believe these are for both chromeos and windows?
> 
> notification_close_windows*.png is for Windows only. There already are
> inotification_close*.png files that are for ChromeOS (and perhaps other
> platforms when we support those).
> 
> notification_expand*.png is for Windows and Chrome OS. It's just a rename of
the
> existing notifications_expand*.png (the naming scheme of the originals was
> inconsistent with the other resource files).

can you put _windows_*.png to win subdirectory instead, and remove _windows_
from the name?

[dharcourt, 2013-04-19 22:36:24]

On 2013/04/19 22:26:58, oshima wrote:
> On 2013/04/19 21:32:14, dharcourt wrote:
> > On 2013/04/19 20:03:17, oshima wrote:
> > > On 2013/04/19 19:40:34, dharcourt wrote:
> > > 
> > > I believe these are for both chromeos and windows?
> > 
> > notification_close_windows*.png is for Windows only. There already are
> > inotification_close*.png files that are for ChromeOS (and perhaps other
> > platforms when we support those).
> > 
> > notification_expand*.png is for Windows and Chrome OS. It's just a rename of
> the
> > existing notifications_expand*.png (the naming scheme of the originals was
> > inconsistent with the other resource files).
> 
> can you put _windows_*.png to win subdirectory instead, and remove _windows_
> from the name?

Funny, I was just about to walk over to ask you if I should do that, as Justin
suggested it in a separate review.

Now done, thanks!

[oshima, 2013-04-19 23:17:42]

lgtm

[dharcourt, 2013-04-19 23:47:30]

Committed patchset #3 manually as r195341 (presubmit successful).