Receive app notifications in SimpleCache, so we save our index file

net/android/simple_cache_activity_status_notifier.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/android/simple_cache_activity_status_notifier.h"
+
+#include "base/android/jni_android.h"
+#include "base/basictypes.h"
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/callback.h"
+#include "base/logging.h"
+#include "base/message_loop.h"
+#include "base/message_loop_proxy.h"
+#include "base/task_runner.h"
+
+#include "jni/SimpleCacheActivityStatusNotifier_jni.h"
+
+namespace net {
+
+SimpleCacheActivityStatusNotifier::SimpleCacheActivityStatusNotifier(
+    base::SingleThreadTaskRunner* callback_runner,
+    const ActivityStatusChangedCallback& notify_callback) :
+    callback_runner_(callback_runner),
+    notify_callback_(notify_callback) {
+  // TODO(felipeg): Do we have to call DetachFromVM somewhere ? I don't see

[Philippe, 2013/04/22 11:35:48]

No, you can remove this comment.

[felipeg, 2013/04/22 16:14:32]

Done.

+  // other code doing that.
+  JNIEnv* env = base::android::AttachCurrentThread();
+  CHECK(env);
+  java_obj_.Reset(
+      Java_SimpleCacheActivityStatusNotifier_NewInstance(

[Philippe, 2013/04/22 11:35:48]

The threading is dangerously subtle here. I guess this constructor is called on
the IO thread but you are calling here the Java side (still on the IO thread)
which accesses a UI thread singleton. We can have an offline discussion to
address this.

[felipeg, 2013/04/22 16:14:32]

Done.

+          env, reinterpret_cast<jint>(this)));
+}
+
+SimpleCacheActivityStatusNotifier::~SimpleCacheActivityStatusNotifier() {}
+
+void SimpleCacheActivityStatusNotifier::NotifyActivityStatusChanged(
+    JNIEnv* env,
+    jobject obj,
+    jint j_new_activity_status) {
+  ActivityStatus new_activity_status =
+      static_cast<ActivityStatus>(j_new_activity_status);
+  if (callback_runner_ && !notify_callback_.is_null()) {

[Philippe, 2013/04/22 11:35:48]

I would add a DCHECK(callback_runner_) in the constructor, make its
scoped_refptr non-reassignable (with const) and remove the callback_runner_
check here. This can cause subtle bugs.

[felipeg, 2013/04/22 16:14:32]

Done.

+    callback_runner_->PostTask(FROM_HERE, base::Bind(notify_callback_,
+                                                     new_activity_status));
+  }
+}
+
+// static
+bool SimpleCacheActivityStatusNotifier::Register(JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}
+
+}  // net

[Philippe, 2013/04/22 11:35:48]

Nit: namespace net

[felipeg, 2013/04/22 16:14:32]

Done.