Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1436173002: Oilpan: account for V8NPObject::rootObject bare pointer. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: account for V8NPObject::rootObject bare pointer. R=haraken BUG=553613 Committed: https://crrev.com/b2470f9c95914c80189527ab7f3c17d3a1576ec2 Cr-Commit-Position: refs/heads/master@{#359319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/NPV8Object.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
5 years, 1 month ago (2015-11-12 10:53:10 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-12 14:18:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436173002/1
5 years, 1 month ago (2015-11-12 14:54:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 15:22:14 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:07:27 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b2470f9c95914c80189527ab7f3c17d3a1576ec2
Cr-Commit-Position: refs/heads/master@{#359319}

Powered by Google App Engine
This is Rietveld 408576698