Issue 1436153003: Merge to XFA: Clear decoders after the image decoder in the /Filter array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1436153003: Merge to XFA: Clear decoders after the image decoder in the /Filter array. (Closed)

Created:
5 years, 1 month ago by Oliver Chang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Clear decoders after the image decoder in the /Filter array. During decoding, when an image decoder is encountered, any subsequent decoders are ignored, but remain in the array. However, later on CPDF_DIBSource::ValidateDictParam expects the image decoder to be the last in the array, causing issues. A check is also added in CPDF_DIBSource::GetScanline to ensure that the calculated pitch value is <= the (4-aligned) pitch value in the cached bitmap to prevent future issues. Also cleans up some NULL usages. BUG=552046 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1406943005 . (cherry picked from commit 182d129bcee8f7731b9bbfde0064295ad3b37271) Committed: https://pdfium.googlesource.com/pdfium/+/437c23363b9be8d681e5ba76827b2fb5af53c8bf

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -15 lines)			Patch
M	core/include/fpdfapi/fpdf_objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp	View	1 chunk	+10 lines, -5 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
A	testing/resources/bug_552046.in	View	Binary file		0 comments	Download
A	testing/resources/bug_552046.pdf	View	Binary file		0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Oliver Chang

5 years, 1 month ago (2015-11-12 18:52:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
437c23363b9be8d681e5ba76827b2fb5af53c8bf (presubmit successful).

Expand Messages | Collapse Messages