Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1436143002: Oilpan: add missing tracing of Page::m_chromeClient. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: add missing tracing of Page::m_chromeClient. R=haraken BUG=553613 Committed: https://crrev.com/de7c001547721316858dc518dca17f8654275449 Cr-Commit-Position: refs/heads/master@{#359310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/page/Page.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
5 years, 1 month ago (2015-11-12 09:59:46 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-12 10:14:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436143002/1
5 years, 1 month ago (2015-11-12 11:49:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 12:55:46 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:06:59 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/de7c001547721316858dc518dca17f8654275449
Cr-Commit-Position: refs/heads/master@{#359310}

Powered by Google App Engine
This is Rietveld 408576698