Use PathService in installer::GetModulePath().

chrome/installer/util/module_util_win.cc

Index: chrome/installer/util/module_util_win.cc
diff --git a/chrome/installer/util/module_util_win.cc b/chrome/installer/util/module_util_win.cc
index c589263690a9c127ca795d8b75e3b449a2fdca6f..1c3facf74e3fafaeb2be6544e1892c62e758c42a 100644
--- a/chrome/installer/util/module_util_win.cc
+++ b/chrome/installer/util/module_util_win.cc
@@ -8,6 +8,7 @@
 
 #include "base/file_version_info.h"
 #include "base/files/file.h"
+#include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
@@ -19,9 +20,17 @@ namespace {
 
 // Returns the directory in which the currently running executable resides.
 base::FilePath GetExecutableDir() {
-  base::char16 path[MAX_PATH];
-  ::GetModuleFileNameW(nullptr, path, MAX_PATH);
-  return base::FilePath(path).DirName();
+  base::char16 path_buffer[MAX_PATH];
+  ::GetModuleFileNameW(nullptr, path_buffer, MAX_PATH);
+  base::FilePath path(path_buffer);
+
+  // When debugging Chrome from the gyp-generated Visual Studio solution, the

[gab, 2015/11/12 18:10:30]

You mean non-ninja builds? Those are not supported AFAIK.

Otherwise, our official builds use gyp-generated builds? Or is this Debug only?

(Not sure I understand why you're seeing this, but it isn't a broader issue)

[fdoray, 2015/11/12 18:27:23]

When GYP_GENERATORS is set to "ninja,msvs-ninja", a chrome.sln file is
generated. If you click "Local Windows Debugger" to launch Chrome in the VS
debugger, ::GetModuleFileNameW() (above) returns a path with a traversal
component "..", and ModuleCanBeRead() (below) fails because base::File doesn't
support path traversal components. This bug was reported to me here: 
crbug.com/554514

Non-ninja builds are not supported, but generating a VS solution to edit
files/debug chrome seems to still be supported
(https://code.google.com/p/chromium/codesearch#chromium/src/docs/ninja_build.m...).

+  // value returned by ::GetModuleFileNameW can contain a path traversal '..'
+  // component, which isn't supported by base::File.
+  if (path.ReferencesParent())
+    path = base::MakeAbsoluteFilePath(path);
+
+  return path.DirName();
 }
 
 // Returns the version in the current module's version resource or the empty