Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1436103002: Move type converter unittests to separate binary (Closed)

Created:
5 years, 1 month ago by jamesr
Modified:
5 years, 1 month ago
Reviewers:
viettrungluu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move type converter unittests to separate binary There's no reason to lump the converter unit tests into mojo_common_unittests as the converters are not under mojo/common. It is also inconvenient to have the test targets in mojo/common as consumers like flutter that want to use mojo/common do not necessarily want to depend on converters they don't use. This moves the converter test targets into their own binary, mojo_converters_unittests, and adds that to the unittest list so mojob.py runs it. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/84ca926ffd1367cfa5213410d67bb7e66537388e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
A mojo/converters/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/tools/data/unittests View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
5 years, 1 month ago (2015-11-12 02:19:32 UTC) #2
viettrungluu
lgtm
5 years, 1 month ago (2015-11-12 02:33:11 UTC) #3
jamesr
5 years, 1 month ago (2015-11-12 02:44:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84ca926ffd1367cfa5213410d67bb7e66537388e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698