Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 14361002: Use GetInverse (Closed)

Created:
7 years, 8 months ago by oshima
Modified:
7 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Use GetInverse Rotation matrixes are normalized (and will soon changed to handle 90 rotations in special form), so no need to have separate inverse matrix. BUG=222483 TEST=no functionality change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195238

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M ash/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
M ash/ash_root_window_transformer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_root_window_transformer.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ash/display/display_controller.cc View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
7 years, 8 months ago (2013-04-18 18:19:06 UTC) #1
oshima
7 years, 8 months ago (2013-04-18 18:19:25 UTC) #2
James Cook
LGTM - I trust that GetInverse() is going to be changed to eliminate the computational ...
7 years, 8 months ago (2013-04-18 18:46:16 UTC) #3
oshima
On 2013/04/18 18:46:16, James Cook (Chromium) wrote: > LGTM - I trust that GetInverse() is ...
7 years, 8 months ago (2013-04-18 18:49:51 UTC) #4
James Cook
On 2013/04/18 18:49:51, oshima wrote: > On 2013/04/18 18:46:16, James Cook (Chromium) wrote: > > ...
7 years, 8 months ago (2013-04-18 19:08:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14361002/5001
7 years, 8 months ago (2013-04-18 19:26:49 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30344
7 years, 8 months ago (2013-04-18 23:16:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14361002/5001
7 years, 8 months ago (2013-04-18 23:23:51 UTC) #8
commit-bot: I haz the power
Failed to apply patch for ash/OWNERS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-19 18:25:55 UTC) #9
oshima
7 years, 8 months ago (2013-04-19 18:27:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r195238 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698