include/core/SkTypes.h - Issue 1436033003: skstd -> std for unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTypes.h

Issue 1436033003: skstd -> std for unique_ptr (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Android fix? Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkTypes.h

diff --git a/include/core/SkTypes.h b/include/core/SkTypes.h

index 5720c30970e5d2ce1ad9f69922caa6a32eeb1163..b3bcc19c170af462845e0342c685a841d6a930c5 100644

--- a/include/core/SkTypes.h

+++ b/include/core/SkTypes.h

@@ -257,7 +257,11 @@ typedef uint8_t SkBool8;

/** Returns 0 or 1 based on the condition

-#define SkToBool(cond) ((cond) != 0)

+#if defined(_MSC_VER)

+ #define SkToBool(cond) (!!(cond)) // MSVC doesn't like a cast.

+#else

+ #define SkToBool(cond) static_cast<bool>(cond)

+#endif

#define SK_MaxS16 32767

#define SK_MinS16 -32767