Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1436033003:
skstd -> std for unique_ptr (Closed)
Descriptionskstd -> std for unique_ptr
TBR=reed@google.com
No public API changes.
BUG=skia:4564
Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065
Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c
Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1436033003
Committed: https://skia.googlesource.com/skia/+/ccf1de0d9aa75f29829f1c4c462214b991fd8c9e
Patch Set 1 #Patch Set 2 : missed #Patch Set 3 : rebase #Patch Set 4 : ? #Patch Set 5 : revert #Patch Set 6 : static_cast #Patch Set 7 : tmpl #Patch Set 8 : type the 0 #Patch Set 9 : spot fix #Patch Set 10 : ugly clang workaround #Patch Set 11 : ugly clang workaround 2 #Patch Set 12 : rebase #Patch Set 13 : !! #Patch Set 14 : revert ugly hack #Patch Set 15 : guh #Patch Set 16 : rebase #Patch Set 17 : Android fix? #
Total comments: 1
Patch Set 18 : rebase, retry #Patch Set 19 : rm #Patch Set 20 : compose #Patch Set 21 : compose more #Patch Set 22 : missed #Patch Set 23 : more composition #Patch Set 24 : more functions #
Messages
Total messages: 127 (64 generated)
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
mtklein@google.com changed reviewers: + bungeman@google.com
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/160001
lgtm
Description was changed from ========== skstd -> std for unique_ptr BUG=skia: ========== to ========== skstd -> std for unique_ptr No public API changes. TBR=reed@google.com BUG=skia: ==========
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/160001
Description was changed from ========== skstd -> std for unique_ptr No public API changes. TBR=reed@google.com BUG=skia: ========== to ========== skstd -> std for unique_ptr No public API changes. TBR=reed@google.com ==========
Description was changed from ========== skstd -> std for unique_ptr No public API changes. TBR=reed@google.com ========== to ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 ==========
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50
Message was sent while issue was closed.
A revert of this CL (patchset #9 id:160001) has been created in https://codereview.chromium.org/1446413002/ by mtklein@google.com. The reason for reverting is: 10.9 bots are too old too..
Description was changed from ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 ========== to ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot ==========
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/200001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/220001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/260001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/280001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/300001
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com Link to the patchset: https://codereview.chromium.org/1436033003/#ps300001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/300001
Message was sent while issue was closed.
Committed patchset #16 (id:300001) as https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065
Message was sent while issue was closed.
A revert of this CL (patchset #16 id:300001) has been created in https://codereview.chromium.org/1467333002/ by mtklein@google.com. The reason for reverting is: Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release has not updated yet..
Message was sent while issue was closed.
Description was changed from ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 ========== to ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot,Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 ==========
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/300001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, no build URL)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/300001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, no build URL)
Description was changed from ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot,Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 ========== to ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 ==========
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/300001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/300001
Message was sent while issue was closed.
Description was changed from ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 ========== to ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c ==========
Message was sent while issue was closed.
Committed patchset #16 (id:300001) as https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c
Message was sent while issue was closed.
A revert of this CL (patchset #16 id:300001) has been created in https://codereview.chromium.org/1482343002/ by mtklein@google.com. The reason for reverting is: Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release.
Message was sent while issue was closed.
Description was changed from ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c ========== to ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c ==========
The CQ bit was checked by mtklein@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com Link to the patchset: https://codereview.chromium.org/1436033003/#ps320001 (title: "Android fix?")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/320001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX...)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/320001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX...)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/320001
Message was sent while issue was closed.
Description was changed from ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c ========== to ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907 ==========
Message was sent while issue was closed.
Committed patchset #17 (id:320001) as https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907
Message was sent while issue was closed.
A revert of this CL (patchset #17 id:320001) has been created in https://codereview.chromium.org/1498583002/ by mtklein@google.com. The reason for reverting is: Chromium bots can't handle forward declared types, e.g. struct Foo { int x,y; std::unique_ptr<Foo> next; }; https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....
Message was sent while issue was closed.
https://codereview.chromium.org/1436033003/diff/320001/include/core/SkRefCnt.h File include/core/SkRefCnt.h (right): https://codereview.chromium.org/1436033003/diff/320001/include/core/SkRefCnt.... include/core/SkRefCnt.h:194: Does adding something like using inherited_t = std::unique_ptr<T, SkTUnref<T>>; SkAutoTUnref& operator=(SkAutoTUnref&& that) { inherited_t::operator=(std::move(that)); return *this; } work around the issue with libc++? I'm not sure this is even entirely correct, but it might be interesting as a workaround until we can get good stls. Just because, here is an old discussion of this very issue http://lists.llvm.org/pipermail/llvm-dev/2012-September/053876.html and was fixed with http://llvm.org/viewvc/llvm-project?view=revision&revision=234886 .
Message was sent while issue was closed.
On 2015/12/02 22:27:13, bungeman1 wrote: > https://codereview.chromium.org/1436033003/diff/320001/include/core/SkRefCnt.h > File include/core/SkRefCnt.h (right): > > https://codereview.chromium.org/1436033003/diff/320001/include/core/SkRefCnt.... > include/core/SkRefCnt.h:194: > Does adding something like > > using inherited_t = std::unique_ptr<T, SkTUnref<T>>; > > SkAutoTUnref& operator=(SkAutoTUnref&& that) { > inherited_t::operator=(std::move(that)); > return *this; > } > > work around the issue with libc++? I'm not sure this is even entirely correct, > but it might be interesting as a workaround until we can get good stls. > > Just because, here is an old discussion of this very issue > http://lists.llvm.org/pipermail/llvm-dev/2012-September/053876.html and was > fixed with http://llvm.org/viewvc/llvm-project?view=revision&revision=234886 . I just wanted to state here that I've finally figured out why the above change fixed the issue. Because the new code uses _VSTD::__is_assignable_test the name is found with an unqualified lookup of _VSTD followed by a qualified lookup of __is_assignable_test. In the old code it was just __is_assignable_test which required an argument-dependent lookup to find _VSTD::__is_assignable_test, but this requires that the arguments to __is_assignable_test be complete so that the lookup can be completed.
Message was sent while issue was closed.
On 2015/12/02 at 22:50:37, bungeman wrote: > On 2015/12/02 22:27:13, bungeman1 wrote: > > https://codereview.chromium.org/1436033003/diff/320001/include/core/SkRefCnt.h > > File include/core/SkRefCnt.h (right): > > > > https://codereview.chromium.org/1436033003/diff/320001/include/core/SkRefCnt.... > > include/core/SkRefCnt.h:194: > > Does adding something like > > > > using inherited_t = std::unique_ptr<T, SkTUnref<T>>; > > > > SkAutoTUnref& operator=(SkAutoTUnref&& that) { > > inherited_t::operator=(std::move(that)); > > return *this; > > } > > > > work around the issue with libc++? I'm not sure this is even entirely correct, > > but it might be interesting as a workaround until we can get good stls. > > > > Just because, here is an old discussion of this very issue > > http://lists.llvm.org/pipermail/llvm-dev/2012-September/053876.html and was > > fixed with http://llvm.org/viewvc/llvm-project?view=revision&revision=234886 . > > I just wanted to state here that I've finally figured out why the above change fixed the issue. Because the new code uses _VSTD::__is_assignable_test the name is found with an unqualified lookup of _VSTD followed by a qualified lookup of __is_assignable_test. In the old code it was just __is_assignable_test which required an argument-dependent lookup to find _VSTD::__is_assignable_test, but this requires that the arguments to __is_assignable_test be complete so that the lookup can be completed. So do you think this will still work-around? I'm happy to try it. using inherited_t = std::unique_ptr<T, SkTUnref<T>>; SkAutoTUnref& operator=(SkAutoTUnref&& that) { inherited_t::operator=(std::move(that)); return *this; }
Message was sent while issue was closed.
On 2015/12/02 at 22:52:00, mtklein wrote: > On 2015/12/02 at 22:50:37, bungeman wrote: > > On 2015/12/02 22:27:13, bungeman1 wrote: > > > https://codereview.chromium.org/1436033003/diff/320001/include/core/SkRefCnt.h > > > File include/core/SkRefCnt.h (right): > > > > > > https://codereview.chromium.org/1436033003/diff/320001/include/core/SkRefCnt.... > > > include/core/SkRefCnt.h:194: > > > Does adding something like > > > > > > using inherited_t = std::unique_ptr<T, SkTUnref<T>>; > > > > > > SkAutoTUnref& operator=(SkAutoTUnref&& that) { > > > inherited_t::operator=(std::move(that)); > > > return *this; > > > } > > > > > > work around the issue with libc++? I'm not sure this is even entirely correct, > > > but it might be interesting as a workaround until we can get good stls. > > > > > > Just because, here is an old discussion of this very issue > > > http://lists.llvm.org/pipermail/llvm-dev/2012-September/053876.html and was > > > fixed with http://llvm.org/viewvc/llvm-project?view=revision&revision=234886 . > > > > I just wanted to state here that I've finally figured out why the above change fixed the issue. Because the new code uses _VSTD::__is_assignable_test the name is found with an unqualified lookup of _VSTD followed by a qualified lookup of __is_assignable_test. In the old code it was just __is_assignable_test which required an argument-dependent lookup to find _VSTD::__is_assignable_test, but this requires that the arguments to __is_assignable_test be complete so that the lookup can be completed. > > So do you think this will still work-around? I'm happy to try it. > > using inherited_t = std::unique_ptr<T, SkTUnref<T>>; > > SkAutoTUnref& operator=(SkAutoTUnref&& that) { > inherited_t::operator=(std::move(that)); > return *this; > } (I think our particular problem is with SkAutoTDelete, but should be the same principle, right?)
Message was sent while issue was closed.
On 2015/12/02 22:52:30, mtklein wrote: > On 2015/12/02 at 22:52:00, mtklein wrote: > > On 2015/12/02 at 22:50:37, bungeman wrote: > > > On 2015/12/02 22:27:13, bungeman1 wrote: > > > > > https://codereview.chromium.org/1436033003/diff/320001/include/core/SkRefCnt.h > > > > File include/core/SkRefCnt.h (right): > > > > > > > > > https://codereview.chromium.org/1436033003/diff/320001/include/core/SkRefCnt.... > > > > include/core/SkRefCnt.h:194: > > > > Does adding something like > > > > > > > > using inherited_t = std::unique_ptr<T, SkTUnref<T>>; > > > > > > > > SkAutoTUnref& operator=(SkAutoTUnref&& that) { > > > > inherited_t::operator=(std::move(that)); > > > > return *this; > > > > } > > > > > > > > work around the issue with libc++? I'm not sure this is even entirely > correct, > > > > but it might be interesting as a workaround until we can get good stls. > > > > > > > > Just because, here is an old discussion of this very issue > > > > http://lists.llvm.org/pipermail/llvm-dev/2012-September/053876.html and > was > > > > fixed with > http://llvm.org/viewvc/llvm-project?view=revision&revision=234886 . > > > > > > I just wanted to state here that I've finally figured out why the above > change fixed the issue. Because the new code uses _VSTD::__is_assignable_test > the name is found with an unqualified lookup of _VSTD followed by a qualified > lookup of __is_assignable_test. In the old code it was just __is_assignable_test > which required an argument-dependent lookup to find _VSTD::__is_assignable_test, > but this requires that the arguments to __is_assignable_test be complete so that > the lookup can be completed. > > > > So do you think this will still work-around? I'm happy to try it. > > > > using inherited_t = std::unique_ptr<T, SkTUnref<T>>; > > > > SkAutoTUnref& operator=(SkAutoTUnref&& that) { > > inherited_t::operator=(std::move(that)); > > return *this; > > } > > (I think our particular problem is with SkAutoTDelete, but should be the same > principle, right?) Maybe, I'm not sure it will work yet, but it might prevent ADL on the operator= I was tempted to blame the android ndk r9 issue on https://llvm.org/bugs/show_bug.cgi?id=22771 , which was fixed with http://llvm.org/viewvc/llvm-project?view=revision&revision=233552 . While that may also cause issues, it appears that the issue seen is a direct result of https://android.googlesource.com/platform/ndk.git/+/087684a3e74b00e8db5d9a310... . This change is still present and they dont' appear to be aware of the problem. Our Android builds are using a less molested stl derived from the one which shipped with gcc 4.9. I believe we'll get the same issues if we build with the clang (with Android 'adjustments') ndk toolchain.
Message was sent while issue was closed.
Description was changed from ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907 ========== to ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Message was sent while issue was closed.
Description was changed from ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/400001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/400001
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/420001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/420001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/460001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/460001
The CQ bit was unchecked by mtklein@chromium.org
The CQ bit was checked by mtklein@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com Link to the patchset: https://codereview.chromium.org/1436033003/#ps460001 (title: "more functions")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1436033003/460001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1436033003/460001
Message was sent while issue was closed.
Description was changed from ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== skstd -> std for unique_ptr TBR=reed@google.com No public API changes. BUG=skia:4564 Committed: https://skia.googlesource.com/skia/+/755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/06189155d987db5c7e69015f6ea87c2168d6a065 Committed: https://skia.googlesource.com/skia/+/70e8dfca4a7f5bce97b8021a6e378c4828b09c8c Committed: https://skia.googlesource.com/skia/+/dadfc245cc9a0279ff7b73da3344f2ca5d139907 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/ccf1de0d9aa75f29829f1c4c462214b991fd8c9e ==========
Message was sent while issue was closed.
Committed patchset #24 (id:460001) as https://skia.googlesource.com/skia/+/ccf1de0d9aa75f29829f1c4c462214b991fd8c9e
Message was sent while issue was closed.
A revert of this CL (patchset #24 id:460001) has been created in https://codereview.chromium.org/1626873004/ by mtklein@google.com. The reason for reverting is: Still need an answer for SkAdvancedTypefaceMetrics (at least for Google3 iOS build)..
Message was sent while issue was closed.
I'm starting to think we should just give up here and implement SkAutoTDelete/SkAutoTUnref/SkAutoCallVProc/SkAutoCallIProc manually like we used to. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
