Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: ports/samba/build.sh

Issue 1435953002: Consistent --host and --build arguments to configure (Closed) Base URL: https://chromium.googlesource.com/external/naclports.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ports/samba/build.sh
diff --git a/ports/samba/build.sh b/ports/samba/build.sh
index 840ef7c14d04222c3805fe31850ca893cd04c15d..b7275eac4e5a147fcf11fb31d6131ad2003c15aa 100755
--- a/ports/samba/build.sh
+++ b/ports/samba/build.sh
@@ -9,20 +9,8 @@ BUILD_DIR=${SRC_DIR}
EnableGlibcCompat
ConfigureStep() {
- conf_build=$(/bin/sh "${SCRIPT_DIR}/config.guess")
-
SetupCrossEnvironment
- local CONFIGURE=${NACL_CONFIGURE_PATH:-${SRC_DIR}/configure}
- local conf_host=${NACL_CROSS_PREFIX}
- if [ "${NACL_ARCH}" = "pnacl" -o "${NACL_ARCH}" = "emscripten" ]; then
- # The PNaCl tools use "pnacl-" as the prefix, but config.sub
- # does not know about "pnacl". It only knows about "le32-nacl".
- # Unfortunately, most of the config.subs here are so old that
- # it doesn't know about that "le32" either. So we just say "nacl".
- conf_host="nacl"
- fi
-
# Inject a shim that speed up pnacl invocations for configure.
if [ "${NACL_ARCH}" = "pnacl" ]; then
local PNACL_CONF_SHIM="${TOOLS_DIR}/pnacl-configure-shim.py"
@@ -36,8 +24,8 @@ ConfigureStep() {
# For example a trivial PNaCl binary can sometimes run on the linux host if
# it has the correct LLVM bimfmt support. What is more, autoconf will
# generate a warning if only --host is specified.
- LogExecute "${CONFIGURE}" \
- --build=${conf_build} \
+ LogExecute "${SRC_DIR}/configure" \
+ --build=${CONF_BUILD} \
--hostcc=gcc \
--cross-compile \
--cross-answers=${START_DIR}/answers \
« no previous file with comments | « ports/ruby/build.sh ('k') | ports/sdl-tests/build.sh » ('j') | ports/sdl2-tests/build.sh » ('J')

Powered by Google App Engine
This is Rietveld 408576698