Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1435953002: Consistent --host and --build arguments to configure (Closed)

Created:
5 years, 1 month ago by Sam Clegg
Modified:
5 years ago
Reviewers:
gdeepti
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Consistent --host and --build arguments to configure Also, add some logging to the sdl/sdl2-tests and remove unused configure are from sdl2-tests configure call. BUG= Committed: https://chromium.googlesource.com/webports/+/b64c996aa44c84ed0aff9fd63b21cf53df7260a7

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -86 lines) Patch
M build_tools/common.sh View 1 2 3 4 chunks +14 lines, -15 lines 0 comments Download
M ports/dosbox/build.sh View 1 1 chunk +1 line, -10 lines 0 comments Download
M ports/ruby/build.sh View 1 1 chunk +2 lines, -10 lines 0 comments Download
M ports/samba/build.sh View 1 2 3 2 chunks +2 lines, -13 lines 0 comments Download
M ports/sdl-tests/build.sh View 1 1 chunk +7 lines, -12 lines 0 comments Download
M ports/sdl2-tests/build.sh View 1 1 chunk +8 lines, -16 lines 0 comments Download
M ports/sdl2/build.sh View 1 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
Sam Clegg
5 years, 1 month ago (2015-11-11 19:27:11 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435953002/20001
5 years, 1 month ago (2015-11-11 19:27:16 UTC) #5
gdeepti
lgtm https://codereview.chromium.org/1435953002/diff/20001/ports/sdl2-tests/build.sh File ports/sdl2-tests/build.sh (left): https://codereview.chromium.org/1435953002/diff/20001/ports/sdl2-tests/build.sh#oldcode82 ports/sdl2-tests/build.sh:82: --disable-pthread-sem Any reason why the two configure options ...
5 years, 1 month ago (2015-11-11 19:39:44 UTC) #6
Sam Clegg
On 2015/11/11 19:39:44, gdeepti wrote: > lgtm > > https://codereview.chromium.org/1435953002/diff/20001/ports/sdl2-tests/build.sh > File ports/sdl2-tests/build.sh (left): > ...
5 years, 1 month ago (2015-11-11 19:41:16 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: naclports-linux-glibc-1 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-1/builds/1439)
5 years, 1 month ago (2015-11-12 00:03:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435953002/20001
5 years, 1 month ago (2015-11-12 18:33:37 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: naclports-linux-glibc-5 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-5/builds/113)
5 years, 1 month ago (2015-11-12 22:42:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435953002/20001
5 years, 1 month ago (2015-11-13 00:32:05 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: naclports-linux-clang-3 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-3/builds/857)
5 years, 1 month ago (2015-11-13 02:43:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435953002/20001
5 years, 1 month ago (2015-11-13 17:59:14 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: naclports-linux-glibc-1 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-1/builds/1445)
5 years, 1 month ago (2015-11-14 01:23:18 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435953002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435953002/60001
5 years ago (2015-12-18 03:10:39 UTC) #26
commit-bot: I haz the power
5 years ago (2015-12-18 07:50:01 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/webports/+/b64c996aa44c84ed0aff9fd63b21cf53...

Powered by Google App Engine
This is Rietveld 408576698