PageVisibility API: Ensure bubbling events are generated

Changed 'visibilitychange' event to a bubble event as defined in w3c docs.

Also changed the API for the prefixed version to maintain compatibility between the two.

This is an interop issue, Firefox bubbles the event while Safari does not, but I think we should match Firefox.

See http://www.w3.org/TR/page-visibility/#sec-processing-model

BUG=501821
Committed: https://crrev.com/fc6186bd5847e555eeeee68300be425d3de3c3aa
Cr-Commit-Position: refs/heads/master@{#361352}

[chongz, 2015-11-11 21:18:37]

Description was changed from

==========
Chenged 'visibilitychange' to bubble event

As defined in w3c docs 'visibilitychange' event should bubble

See http://www.w3.org/TR/page-visibility/#sec-processing-model

BUG=501821
==========

to

==========
Chenged 'visibilitychange' to bubble event

As defined in w3c docs 'visibilitychange' event should bubble

See http://www.w3.org/TR/page-visibility/#sec-processing-model

BUG=501821
==========

[chongz, 2015-11-11 21:18:37]

chongz@chromium.org changed reviewers:
+ dtapuska@chromium.org

[chongz, 2015-11-12 18:25:48]

Description was changed from

==========
Chenged 'visibilitychange' to bubble event

As defined in w3c docs 'visibilitychange' event should bubble

See http://www.w3.org/TR/page-visibility/#sec-processing-model

BUG=501821
==========

to

==========
Changed 'visibilitychange' to bubble event

As defined in w3c docs 'visibilitychange' event should bubble

See http://www.w3.org/TR/page-visibility/#sec-processing-model

BUG=501821
==========

[dtapuska, 2015-11-13 00:25:38]

On 2015/11/12 18:25:48, chongz wrote:
> Description was changed from
> 
> ==========
> Chenged 'visibilitychange' to bubble event
> 
> As defined in w3c docs 'visibilitychange' event should bubble
> 
> See http://www.w3.org/TR/page-visibility/#sec-processing-model
> 
> BUG=501821
> ==========
> 
> to
> 
> ==========
> Changed 'visibilitychange' to bubble event
> 
> As defined in w3c docs 'visibilitychange' event should bubble
> 
> See http://www.w3.org/TR/page-visibility/#sec-processing-model
> 
> BUG=501821
> ==========

lgtm with some nits...

Change the description to have the first line being descriptive.

Something like "PageVisibility API: Ensure bubbling events are generated."

And then comment in the text of the description that you are changing the API of
the prefixed version as well to maintain compatibility between the two.

Also indicate this is an interop issue and that other vendors bubble the event.

[dtapuska, 2015-11-13 00:25:58]

dtapuska@chromium.org changed reviewers:
+ davidben@chromium.org

[dtapuska, 2015-11-13 00:26:37]

On 2015/11/13 00:25:38, dtapuska wrote:
> On 2015/11/12 18:25:48, chongz wrote:
> > Description was changed from
> > 
> > ==========
> > Chenged 'visibilitychange' to bubble event
> > 
> > As defined in w3c docs 'visibilitychange' event should bubble
> > 
> > See http://www.w3.org/TR/page-visibility/#sec-processing-model
> > 
> > BUG=501821
> > ==========
> > 
> > to
> > 
> > ==========
> > Changed 'visibilitychange' to bubble event
> > 
> > As defined in w3c docs 'visibilitychange' event should bubble
> > 
> > See http://www.w3.org/TR/page-visibility/#sec-processing-model
> > 
> > BUG=501821
> > ==========
> 
> lgtm with some nits...
> 
> Change the description to have the first line being descriptive.
> 
> Something like "PageVisibility API: Ensure bubbling events are generated."
> 
> And then comment in the text of the description that you are changing the API
of
> the prefixed version as well to maintain compatibility between the two.
> 
> Also indicate this is an interop issue and that other vendors bubble the
event.

Adding davidben@ as he was the one that originally wrote the non-spec compliant
code (or the spec changed under him :-))

[dtapuska, 2015-11-13 00:26:58]

https://codereview.chromium.org/1435893003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/1435893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Document.cpp:1381: // See:
http://www.w3.org/TR/page-visibility/#sec-processing-model
I don't think we need the comments here; it is pretty obvious that it bubbles.

[davidben, 2015-11-16 18:35:49]

On 2015/11/13 00:26:37, dtapuska wrote:
> On 2015/11/13 00:25:38, dtapuska wrote:
> > On 2015/11/12 18:25:48, chongz wrote:
> > > Description was changed from
> > > 
> > > ==========
> > > Chenged 'visibilitychange' to bubble event
> > > 
> > > As defined in w3c docs 'visibilitychange' event should bubble
> > > 
> > > See http://www.w3.org/TR/page-visibility/#sec-processing-model
> > > 
> > > BUG=501821
> > > ==========
> > > 
> > > to
> > > 
> > > ==========
> > > Changed 'visibilitychange' to bubble event
> > > 
> > > As defined in w3c docs 'visibilitychange' event should bubble
> > > 
> > > See http://www.w3.org/TR/page-visibility/#sec-processing-model
> > > 
> > > BUG=501821
> > > ==========
> > 
> > lgtm with some nits...
> > 
> > Change the description to have the first line being descriptive.
> > 
> > Something like "PageVisibility API: Ensure bubbling events are generated."
> > 
> > And then comment in the text of the description that you are changing the
API
> of
> > the prefixed version as well to maintain compatibility between the two.
> > 
> > Also indicate this is an interop issue and that other vendors bubble the
> event.
> 
> Adding davidben@ as he was the one that originally wrote the non-spec
compliant
> code (or the spec changed under him :-))

I was? Er, I don't actually know what the difference between these mores is and
didn't implement Page Visibility API. I just unprefixed it as it'd been
forgotten. Didn't realize there was a difference between our behavior and what
was spec'd. Oops. :-)

Will defer to you all here.

[dtapuska, 2015-11-16 18:37:00]

dtapuska@chromium.org changed reviewers:
+ rbyers@chromium.org

[chongz, 2015-11-16 20:29:17]

Description was changed from

==========
Changed 'visibilitychange' to bubble event

As defined in w3c docs 'visibilitychange' event should bubble

See http://www.w3.org/TR/page-visibility/#sec-processing-model

BUG=501821
==========

to

==========
Changed 'visibilitychange' event to a bubble event as defined in w3c docs.

Also changed the API for the prefixed version to maintain compatibility between
the two.

This is an interop issue, Firefox bubbles the event while Safari does not, but I
think we should match Firefox.

See http://www.w3.org/TR/page-visibility/#sec-processing-model

BUG=501821
==========

[chongz, 2015-11-16 22:02:29]

chongz@chromium.org changed reviewers:
+ skobes@chromium.org
- rbyers@chromium.org

[skobes, 2015-11-23 23:21:05]

lgtm

[chongz, 2015-11-24 03:22:04]

The CQ bit was checked by chongz@chromium.org

[chongz, 2015-11-24 03:22:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/1435893003/#ps20001
(title: "Removed unnecessary comments")

[commit-bot: I haz the power, 2015-11-24 03:23:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435893003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435893003/20001

[commit-bot: I haz the power, 2015-11-24 05:01:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 05:01:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chongz, 2015-11-24 15:49:52]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2015-11-24 15:51:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435893003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435893003/20001

[commit-bot: I haz the power, 2015-11-24 16:22:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 16:23:46]

Patchset 2 (id:??) landed as
https://crrev.com/fc6186bd5847e555eeeee68300be425d3de3c3aa
Cr-Commit-Position: refs/heads/master@{#361352}