Add #includes to password code

Add #includes to password code

These were suggested by git cl lint. Let's get them sorted out so that git cl lint can be used on other CLs without an avalanche of unrelated warnings.

R=vasilii@chromium.org
BUG=549167
Committed: https://crrev.com/46d5481ccea34db000c3393a16fd9d02b5187085
Cr-Commit-Position: refs/heads/master@{#359099}

[vabr (Chromium), 2015-11-11 14:16:29]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-11 14:16:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435883002/1

[vabr (Chromium), 2015-11-11 14:16:49]

Hi Vasilii,

Please take a look.

Thanks,
Vaclav

[commit-bot: I haz the power, 2015-11-11 14:56:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 14:56:20]

Dry run: This issue passed the CQ dry run.

[vasilii, 2015-11-11 15:51:56]

https://codereview.chromium.org/1435883002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/chrome_password_manager_client.cc (right):

https://codereview.chromium.org/1435883002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/chrome_password_manager_client.cc:7: #include
<string>
I found std::string use in the header. Do you want to include it there?

https://codereview.chromium.org/1435883002/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_state.cc (right):

https://codereview.chromium.org/1435883002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_state.cc:7: #include <vector>
It's used in the header. Does the warning goes away if you include it in the
header?

[vabr (Chromium), 2015-11-11 15:59:12]

Thanks, Vasilii!

PTAL.

Vaclav

https://codereview.chromium.org/1435883002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/chrome_password_manager_client.cc (right):

https://codereview.chromium.org/1435883002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/chrome_password_manager_client.cc:7: #include
<string>
On 2015/11/11 15:51:56, vasilii wrote:
> I found std::string use in the header. Do you want to include it there?

The instance in the header is in a signature of an overridden method, there I
would defer to the header defining the original method.

https://codereview.chromium.org/1435883002/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_state.cc (right):

https://codereview.chromium.org/1435883002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_state.cc:7: #include <vector>
On 2015/11/11 15:51:56, vasilii wrote:
> It's used in the header. Does the warning goes away if you include it in the
> header?

Good catch! I only ran the linter on files which were modified in my other CL,
which is probably why I missed the header(s).
Done.

[vasilii, 2015-11-11 16:00:59]

lgtm

[vabr (Chromium), 2015-11-11 16:03:56]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2015-11-11 16:04:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435883002/20001

[commit-bot: I haz the power, 2015-11-11 16:36:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-12 19:57:54]

Patchset 2 (id:??) landed as
https://crrev.com/46d5481ccea34db000c3393a16fd9d02b5187085
Cr-Commit-Position: refs/heads/master@{#359099}