Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1435853002: Register closures using StaticUse. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -37 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +12 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 4 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 1 month ago (2015-11-11 11:12:03 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1435853002/diff/1/pkg/compiler/lib/src/enqueue.dart File pkg/compiler/lib/src/enqueue.dart (right): https://codereview.chromium.org/1435853002/diff/1/pkg/compiler/lib/src/enqueue.dart#newcode634 pkg/compiler/lib/src/enqueue.dart:634: case StaticUseKind.CLOSURE: Merge with previous 2 cases?
5 years, 1 month ago (2015-11-11 11:19:02 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 8b0817c8399812cc020cbb33a7d2f6aad5e1ccc6 (presubmit successful).
5 years, 1 month ago (2015-11-11 11:59:13 UTC) #4
Johnni Winther
5 years, 1 month ago (2015-11-11 18:34:02 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1435853002/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/1435853002/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:634: case StaticUseKind.CLOSURE:
On 2015/11/11 11:19:02, sigurdm wrote:
> Merge with previous 2 cases?

Done.

Powered by Google App Engine
This is Rietveld 408576698