Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1435823003: Fix Omnibox update problem on El Capitan. (Closed)

Created:
5 years, 1 month ago by shrike
Modified:
5 years, 1 month ago
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Omnibox update problem on El Capitan. Force a redraw at the end of the Omnibox popup's animation to ensure that its contents are redrawn after an update on El Capitan. BUG=551007 Committed: https://crrev.com/d23c3995cd1439bc28a1254a9e8ff850c833fbf2 Cr-Commit-Position: refs/heads/master@{#359173}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code refinement. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 2 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
shrike
PTAL
5 years, 1 month ago (2015-11-11 20:17:55 UTC) #3
ccameron
Bouncing -> rohitrao, cause git blame suggests he may know more about this than I ...
5 years, 1 month ago (2015-11-11 20:37:34 UTC) #5
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/1435823003/diff/1/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm (right): https://codereview.chromium.org/1435823003/diff/1/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm#newcode290 chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:290: [[popup_ animator] setFrame:popup_frame display:NO]; Why do we need ...
5 years, 1 month ago (2015-11-11 20:51:27 UTC) #6
shrike
https://codereview.chromium.org/1435823003/diff/1/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm (right): https://codereview.chromium.org/1435823003/diff/1/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm#newcode290 chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:290: [[popup_ animator] setFrame:popup_frame display:NO]; On 2015/11/11 20:51:27, rohitrao wrote: ...
5 years, 1 month ago (2015-11-11 21:40:18 UTC) #7
rohitrao (ping after 24h)
Cool, still lgtm
5 years, 1 month ago (2015-11-11 21:41:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435823003/20001
5 years, 1 month ago (2015-11-11 21:45:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-11 22:18:20 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:01:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d23c3995cd1439bc28a1254a9e8ff850c833fbf2
Cr-Commit-Position: refs/heads/master@{#359173}

Powered by Google App Engine
This is Rietveld 408576698