Fix Omnibox update problem on El Capitan.

Fix Omnibox update problem on El Capitan.

Force a redraw at the end of the Omnibox popup's animation to ensure
that its contents are redrawn after an update on El Capitan.

BUG=551007
Committed: https://crrev.com/d23c3995cd1439bc28a1254a9e8ff850c833fbf2
Cr-Commit-Position: refs/heads/master@{#359173}

[shrike, 2015-11-11 20:17:48]

Description was changed from

==========
Fix Omnibox update problem on El Capitan.

Force a redraw at the end of the Omnibox popup's animation to ensure
that its contents are redrawn after an update on El Capitan.

BUG=551007
==========

to

==========
Fix Omnibox update problem on El Capitan.

Force a redraw at the end of the Omnibox popup's animation to ensure
that its contents are redrawn after an update on El Capitan.

BUG=551007
==========

[shrike, 2015-11-11 20:17:48]

shrike@chromium.org changed reviewers:
+ ccameron@chromium.org

[shrike, 2015-11-11 20:17:55]

PTAL

[ccameron, 2015-11-11 20:37:34]

ccameron@chromium.org changed reviewers:
+ rohitrao@chromium.org

[ccameron, 2015-11-11 20:37:34]

Bouncing -> rohitrao, cause git blame suggests he may know more about this than
I do.

[rohitrao (ping after 24h), 2015-11-11 20:51:27]

lgtm

https://codereview.chromium.org/1435823003/diff/1/chrome/browser/ui/cocoa/omn...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm (right):

https://codereview.chromium.org/1435823003/diff/1/chrome/browser/ui/cocoa/omn...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:290: [[popup_
animator] setFrame:popup_frame display:NO];
Why do we need display:NO here?

[shrike, 2015-11-11 21:40:18]

https://codereview.chromium.org/1435823003/diff/1/chrome/browser/ui/cocoa/omn...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm (right):

https://codereview.chromium.org/1435823003/diff/1/chrome/browser/ui/cocoa/omn...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm:290: [[popup_
animator] setFrame:popup_frame display:NO];
On 2015/11/11 20:51:27, rohitrao wrote:
> Why do we need display:NO here?

I was thinking that would avoid a redundant redraw, but after instrumenting the
code to see what gets drawn when it appears that you get the same number of
redraws regardless. I have updated the code to remove this extra line.

[rohitrao (ping after 24h), 2015-11-11 21:41:52]

Cool, still lgtm

[shrike, 2015-11-11 21:44:51]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2015-11-11 21:45:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435823003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435823003/20001

[commit-bot: I haz the power, 2015-11-11 22:18:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-12 20:01:12]

Patchset 2 (id:??) landed as
https://crrev.com/d23c3995cd1439bc28a1254a9e8ff850c833fbf2
Cr-Commit-Position: refs/heads/master@{#359173}