Issue 1435813002: build: detect the right `ar` tool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1435813002: build: detect the right `ar` tool (Closed)

Created:
5 years, 1 month ago by vapier

Modified:
5 years, 1 month ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

build: detect the right `ar` tool Use automake's AM_PROG_AR helper instead of the default of hardcoding `ar` all the time. When cross-compiling, this can often be the wrong one to use. BUG=google-breakpad:519 R=ted.mielczarek@gmail.com Committed: https://chromium.googlesource.com/breakpad/breakpad/+/ff49f92c36476cf3efe6681edae86159b2dd7b0f

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+511 lines, -6 lines)			Patch
M	Makefile.in	View	5 chunks	+6 lines, -5 lines	0 comments	Download
M	aclocal.m4	View	1 chunk	+60 lines, -0 lines	0 comments	Download
A	autotools/ar-lib	View	1 chunk	+270 lines, -0 lines	0 comments	Download
M	configure	View	3 chunks	+174 lines, -1 line	0 comments	Download
M	configure.ac	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Ted Mielczarek

LGTM (I've worked around this a number of times, not sure why I never thought ...

5 years, 1 month ago (2015-11-11 11:32:09 UTC) #3

vapier

5 years, 1 month ago (2015-11-11 18:43:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ff49f92c36476cf3efe6681edae86159b2dd7b0f (presubmit successful).