Refactor AudioRendererMixer to be more generic.

Refactor AudioRendererMixer to be more generic.

AudioRendererMixer will now work with arbitrary
AudioConverter::InputCallbacks.  Its main value is as a go between
for AudioRendererSink::RenderCallbacks to a single AudioRendererSink.

This refactoring allows WebRTC to reuse the AudioRendererMixer
infrastructure without forking out the ARMM and ARM modules.

BUG=234580
TEST=media_unittests
R=xians@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197522

[DaleCurtis, 2013-04-29 23:23:33]

WDYT?

[no longer working on chromium, 2013-04-30 08:42:23]

thanks for the CL. lgtm % two nits

https://codereview.chromium.org/14358049/diff/1/media/base/audio_converter.cc
File media/base/audio_converter.cc (right):

https://codereview.chromium.org/14358049/diff/1/media/base/audio_converter.cc...
media/base/audio_converter.cc:114: void
AudioConverter::ConvertWithDelay(base::TimeDelta initial_delay,
nit, const base::TimeDelta& ?

https://codereview.chromium.org/14358049/diff/1/media/base/audio_renderer_mix...
File media/base/audio_renderer_mixer_input.cc (right):

https://codereview.chromium.org/14358049/diff/1/media/base/audio_renderer_mix...
media/base/audio_renderer_mixer_input.cc:85: audio_bus,
buffer_delay.InMillisecondsF() + 0.5);
nit, this might trigger compiling warning, explicitly cast it to int ?

[DaleCurtis, 2013-04-30 18:33:21]

Before I submit, does this refactoring look good in the context of what you want
to do with WebRTC?  I.e., if this doesn't actually allow you to reuse, I
wouldn't submit :)

[no longer working on chromium, 2013-04-30 18:55:32]

On 2013/04/30 18:33:21, DaleCurtis wrote:
> Before I submit, does this refactoring look good in the context of what you
want
> to do with WebRTC?  I.e., if this doesn't actually allow you to reuse, I
> wouldn't submit :)

I haven't tried it today, but just by looking at the code, it should work.
What about committing the CL now? I believe this is the right approach to go.

[DaleCurtis, 2013-04-30 19:37:02]

sgtm. will land after try's pass.

[DaleCurtis, 2013-05-01 00:11:52]

Committed patchset #2 manually as r197522 (presubmit successful).