Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: pnacl/driver/pnacl-ld.py

Issue 14358048: Update pnacl/DEPS to bring in stricter ABI checks for metadata (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: change deps Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pnacl/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pnacl/driver/pnacl-ld.py
diff --git a/pnacl/driver/pnacl-ld.py b/pnacl/driver/pnacl-ld.py
index dc57ee1f9d86855caf6095ce51a43cf6a91296fa..fc0511533620971a7751488e6f87dc8f0a762cdb 100755
--- a/pnacl/driver/pnacl-ld.py
+++ b/pnacl/driver/pnacl-ld.py
@@ -378,13 +378,18 @@ def main(argv):
# reintroduce ConstantExprs. However, '-expand-getelementptr'
# must follow '-expand-constant-expr' to expand the
# getelementptr instructions it creates.
- passes = ['-expand-constant-expr',
+ # We place '-strip-metadata' after optimization passes since
+ # optimizations depend on the metadata.
+ passes = ['-strip-metadata',
+ '-expand-constant-expr',
'-expand-getelementptr']
if (not env.getbool('DISABLE_ABI_CHECK') and
not env.getbool('ALLOW_CXX_EXCEPTIONS') and
len(native_objects) == 0):
passes += ['-verify-pnaclabi-module',
- '-verify-pnaclabi-functions']
+ '-verify-pnaclabi-functions',
+ # A flag for the above -verify-pnaclabi-* passes.
+ '-pnaclabi-allow-debug-metadata']
chain.add(DoLLVMPasses(passes),
'expand_features_after_opt.' + bitcode_type)
else:
« no previous file with comments | « pnacl/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698