Web MIDI: implement MIDIConnectionEvent

Source/modules/webmidi/MIDIConnectionEvent.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef MIDIMessageEvent_h
-#define MIDIMessageEvent_h
+#ifndef MIDIConnectionEvent_h
+#define MIDIConnectionEvent_h
 
 #include "core/dom/Event.h"
-#include "wtf/Uint8Array.h"
+#include "modules/webmidi/MIDIPort.h"
 
 namespace WebCore {
 
-struct MIDIMessageEventInit : public EventInit {
-    MIDIMessageEventInit()
-        : receivedTime(0.0)
+struct MIDIConnectionEventInit : public EventInit {
+    MIDIConnectionEventInit()

[haraken, 2013/04/25 06:33:00]

You need to initialize port to 0.

[Takashi Toyoshima, 2013/04/25 07:20:27]

Done.

     {
     };
 
-    double receivedTime;
-    RefPtr<Uint8Array> data;
+    RefPtr<MIDIPort> port;
 };
 
-class MIDIMessageEvent : public Event {
+class MIDIConnectionEvent : public Event {
 public:
-    static PassRefPtr<MIDIMessageEvent> create()
+    static PassRefPtr<MIDIConnectionEvent> create()
     {
-        return adoptRef(new MIDIMessageEvent());
+        return adoptRef(new MIDIConnectionEvent());
     }
 
-    static PassRefPtr<MIDIMessageEvent> create(double receivedTime, PassRefPtr<Uint8Array> data)
+    static PassRefPtr<MIDIConnectionEvent> create(const AtomicString& type)
     {
-        return adoptRef(new MIDIMessageEvent(receivedTime, data));
+        return adoptRef(new MIDIConnectionEvent(type));
     }
 
-    static PassRefPtr<MIDIMessageEvent> create(const AtomicString& type, const MIDIMessageEventInit& initializer)
+    static PassRefPtr<MIDIConnectionEvent> create(const AtomicString& type, PassRefPtr<MIDIPort> port)
     {
-        return adoptRef(new MIDIMessageEvent(type, initializer));
+        return adoptRef(new MIDIConnectionEvent(type, port));
     }
 
-    double receivedTime() { return m_receivedTime; }
-    PassRefPtr<Uint8Array> data() { return m_data; }
+    static PassRefPtr<MIDIConnectionEvent> create(const AtomicString& type, const MIDIConnectionEventInit& initializer)
+    {
+        return adoptRef(new MIDIConnectionEvent(type, initializer));
+    }
+
+    RefPtr<MIDIPort> port() { return m_port; }
+
+    // Event:

[haraken, 2013/04/25 06:33:00]

Nit: Remove the comment.

[Takashi Toyoshima, 2013/04/25 07:20:27]

Done.

+    virtual const AtomicString& interfaceName() const OVERRIDE { return eventNames().interfaceForMIDIConnectionEvent; }
 
 private:
-    MIDIMessageEvent()
-        : m_receivedTime(0.0)
+    MIDIConnectionEvent()
     {
         ScriptWrappable::init(this);
     }
 
-    MIDIMessageEvent(double receivedTime, PassRefPtr<Uint8Array> data)
-        : m_receivedTime(receivedTime)
-        , m_data(data)
+    MIDIConnectionEvent(const AtomicString& type)
+        : Event(type, false, false)
     {
         ScriptWrappable::init(this);
     }
 
-    MIDIMessageEvent(const AtomicString& type, const MIDIMessageEventInit& initializer)
-        : Event(type, initializer)
-        , m_receivedTime(initializer.receivedTime)
-        , m_data(initializer.data)
+    MIDIConnectionEvent(const AtomicString& type, PassRefPtr<MIDIPort> port)

[haraken, 2013/04/25 06:33:00]

Do you really need all of MIDIConnectionEvent(),
MIDIConnectionEvent(AtomicString) and MIDIConnectionEvent(AtomicString,
PassRefPtr<MIDIPort>) ?

[Takashi Toyoshima, 2013/04/25 07:20:27]

First one is used by auto-generated code.
The second one is used for testing in my local branch but I can omit this.
The third one will be used in the real implementation.

+        : Event(type, false, false)
+        , m_port(port)
     {
         ScriptWrappable::init(this);
     }
 
-    double m_receivedTime;
-    RefPtr<Uint8Array> m_data;
+    MIDIConnectionEvent(const AtomicString& type, const MIDIConnectionEventInit& initializer)
+        : Event(type, initializer)
+        , m_port(initializer.port)
+    {
+        ScriptWrappable::init(this);
+    }
+
+    RefPtr<MIDIPort> m_port;
 };
 
 } // namespace WebCore
 
-#endif // MIDIMessageEvent_h
+#endif // MIDIConnectionEvent_h