Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: chrome/browser/ui/omnibox/omnibox_controller.h

Issue 14358005: Omnibox refactor, moved OnResultChanged to OmniboxController (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed unit test. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_controller.h
diff --git a/chrome/browser/ui/omnibox/omnibox_controller.h b/chrome/browser/ui/omnibox/omnibox_controller.h
index 736fcad89bdc889a692a4adc13f16df6a70c3978..dd1d4c802ffbbf9a6020b1951ce5ce54e183d8e7 100644
--- a/chrome/browser/ui/omnibox/omnibox_controller.h
+++ b/chrome/browser/ui/omnibox/omnibox_controller.h
@@ -5,12 +5,17 @@
#ifndef CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_CONTROLLER_H_
#define CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_CONTROLLER_H_
+#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/autocomplete/autocomplete_controller_delegate.h"
class AutocompleteController;
+struct AutocompleteMatch;
+class AutocompleteResult;
+class GURL;
class OmniboxEditModel;
+class OmniboxPopupModel;
class Profile;
// This class controls the various services that can modify the content
@@ -34,11 +39,34 @@ class OmniboxController : public AutocompleteControllerDelegate {
return autocomplete_controller_.get();
}
+ void set_popup_model(OmniboxPopupModel* popup_model) {
+ popup_ = popup_model;
+ }
+
+ // TODO: The edit and popup should be siblings owned by the LocationBarView,
Mathieu 2013/05/03 19:09:02 nit: the edit and popup what? be clearer, as it co
beaudoin 2013/05/04 03:06:51 Done.
+ // making this accessor unnecessary.
+ OmniboxPopupModel* popup_model() const { return popup_; }
+
+ // Turns off keyword mode for the current match.
+ void ClearPopupKeywordMode() const;
+
+ void InfoForCurrentSelection(AutocompleteMatch* match,
+ GURL* alternate_nav_url) const;
+
+ const AutocompleteResult& result() const;
+
+ // TODO(beaudoin): Make private once OmniboxEditModel no longer refers to it.
+ void DoPreconnect(const AutocompleteMatch& match);
+
private:
// Weak, it owns us.
// TODO(beaudoin): Consider defining a delegate to ease unit testing.
OmniboxEditModel* omnibox_edit_model_;
+ Profile* profile_;
+
+ OmniboxPopupModel* popup_;
+
scoped_ptr<AutocompleteController> autocomplete_controller_;
DISALLOW_COPY_AND_ASSIGN(OmniboxController);
« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_controller.cc » ('j') | chrome/browser/ui/omnibox/omnibox_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698