Almost all actions in Declarative Web Request require all_urls host permissions

chrome/browser/extensions/api/declarative/declarative_rule.h

Index: chrome/browser/extensions/api/declarative/declarative_rule.h
diff --git a/chrome/browser/extensions/api/declarative/declarative_rule.h b/chrome/browser/extensions/api/declarative/declarative_rule.h
index e9411550432e17d8ecf20952078e05fdd8c64355..a2dd1f572dd7287f7b6e4a9b5f628e6bc6da0f45 100644
--- a/chrome/browser/extensions/api/declarative/declarative_rule.h
+++ b/chrome/browser/extensions/api/declarative/declarative_rule.h
@@ -15,6 +15,7 @@
 #include <string>
 #include <vector>
 
+#include "base/callback.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/stl_util.h"
@@ -190,9 +191,9 @@ class DeclarativeRule {
 
   // Checks whether the set of |conditions| and |actions| are consistent.
   // Returns true in case of consistency and MUST set |error| otherwise.
-  typedef bool (*ConsistencyChecker)(const ConditionSet* conditions,
-                                     const ActionSet* actions,
-                                     std::string* error);
+  typedef base::Callback<bool(const ConditionSet* conditions,

[vabr (Chromium), 2013/04/25 19:08:03]

I switched to callback here from a bare function pointer so that new checker can
be made from methods or functions with additional arguments (the host permission
checker is one instance).

The alternatives I considered were:
1. Change the function pointer to have most generic list of arguments (adding
Extension* in this case).
That seemed wasteful and confusing.
2. Switching to Callback, and make it a Closure instead, binding the conditions,
actions and error in.
I don't like binding the error in particular, since it is not clear the target
string will be alive when the callback gets called. For leaving the conditions
and actions there I don't have a strong preference.

+                              const ActionSet* actions,
+                              std::string* error)> ConsistencyChecker;
 
   DeclarativeRule(const GlobalRuleId& id,
                   const Tags& tags,
@@ -448,8 +449,8 @@ DeclarativeRule<ConditionT, ActionT>::Create(
     return error_result.Pass();
   CHECK(actions.get());
 
-  if (check_consistency &&
-      !check_consistency(conditions.get(), actions.get(), error)) {
+  if (!check_consistency.is_null() &&
+      !check_consistency.Run(conditions.get(), actions.get(), error)) {
     DCHECK(!error->empty());
     return error_result.Pass();
   }