Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1763)

Unified Diff: chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc

Issue 14358004: Almost all actions in Declarative Web Request require all_urls host permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: All URLs -> all hosts; also rebased Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc b/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc
index 5bf39d051a9e8dc563a87aa31a3d7f0bc2b18e8d..13dc9d89b9e0891fd6b8a4b9cdb60873a7ef729f 100644
--- a/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc
+++ b/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/extensions/api/declarative/declarative_rule.h"
+#include "base/bind.h"
#include "base/message_loop.h"
#include "base/test/values_test_util.h"
#include "base/values.h"
@@ -305,8 +306,12 @@ TEST(DeclarativeRuleTest, Create) {
URLMatcher matcher;
std::string error;
- scoped_ptr<Rule> rule(Rule::Create(matcher.condition_factory(), kExtensionId,
- install_time, json_rule, NULL, &error));
+ scoped_ptr<Rule> rule(Rule::Create(matcher.condition_factory(),
+ kExtensionId,
+ install_time,
+ json_rule,
+ Rule::ConsistencyChecker(),
+ &error));
EXPECT_EQ("", error);
ASSERT_TRUE(rule.get());
@@ -367,7 +372,7 @@ TEST(DeclarativeRuleTest, CheckConsistency) {
json_rule.get()));
scoped_ptr<Rule> rule(
Rule::Create(matcher.condition_factory(), kExtensionId, base::Time(),
- json_rule, &AtLeastOneCondition, &error));
+ json_rule, base::Bind(AtLeastOneCondition), &error));
EXPECT_TRUE(rule);
EXPECT_EQ("", error);
@@ -385,7 +390,7 @@ TEST(DeclarativeRuleTest, CheckConsistency) {
"}"),
json_rule.get()));
rule = Rule::Create(matcher.condition_factory(), kExtensionId, base::Time(),
- json_rule, &AtLeastOneCondition, &error);
+ json_rule, base::Bind(AtLeastOneCondition), &error);
EXPECT_FALSE(rule);
EXPECT_EQ("No conditions", error);
}

Powered by Google App Engine
This is Rietveld 408576698