chrome/browser/extensions/api/web_request/web_request_api.cc - Issue 14358004: Almost all actions in Declarative Web Request require all_urls host permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api.cc

Issue 14358004: Almost all actions in Declarative Web Request require all_urls host permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Without error messages yet Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h ('K') | « chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc ('k') | chrome/browser/extensions/api/web_request/web_request_apitest.cc » ('j') | chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc

index 623af7fd4f94ff1a4f597c5a671d6a67dc286271..aea064c17b08ceac6b4eae4a3aaaada88d92cc46 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api.cc

@@ -1285,7 +1285,8 @@ void ExtensionWebRequestEventRouter::GetMatchingListenersImpl(

continue;

if (!WebRequestPermissions::CanExtensionAccessURL(

- extension_info_map, it->extension_id, url, crosses_incognito, true))

+ extension_info_map, it->extension_id, url, crosses_incognito,

+ WebRequestPermissions::REQUIRE_HOST_PERMISSION))

continue;

bool blocking_listener =