chrome/test/data/extensions/api_test/declarative/api/manifest.json - Issue 14358004: Almost all actions in Declarative Web Request require all_urls host permissions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/declarative/api/manifest.json

Issue 14358004: Almost all actions in Declarative Web Request require all_urls host permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Checker back in rules registry + other Matt's comments + failing tests fixed Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | chrome/test/data/extensions/api_test/webrequest/manifest.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name": "Declarative apitest",	2 "name": "Declarative apitest",

3 "version": "0.1",	3 "version": "0.1",

4 "manifest_version": 2,	4 "manifest_version": 2,

5 "description": "end-to-end browser test for the declarative API",	5 "description": "end-to-end browser test for the declarative API",

6 "background": {	6 "background": {

7 "scripts": ["background.js"]	7 "scripts": ["background.js"]

8 },	8 },

9 "permissions": [	9 "permissions": [

10 "declarativeWebRequest"	10 "declarativeWebRequest", "<all_urls>"
	vabr (Chromium) 2013/04/26 09:58:52 This is necessary for registering the Redirect rul This is necessary for registering the Redirect rule in background.js. This browser test does not care about checking permissions, only the rules loading, so that should be OK.
11 ]	11 ]

12 }	12 }

OLD	NEW