Almost all actions in Declarative Web Request require all_urls host permissions

chrome/browser/extensions/permissions_updater_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/memory/ref_counted.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
+#if defined(OS_WIN)
+#include "base/string_util.h"
+#endif
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_service_unittest.h"
 #include "chrome/browser/extensions/permissions_updater.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_test_util.h"
 #include "chrome/common/extensions/permissions/permission_set.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+using extension_test_util::LoadManifest;
+
 namespace extensions {
 
 namespace {
 
 // A helper class that listens for NOTIFICATION_EXTENSION_PERMISSIONS_UPDATED.
 class PermissionsUpdaterListener : public content::NotificationObserver {
  public:
   PermissionsUpdaterListener()
       : received_notification_(false), waiting_(false) {
     registrar_.Add(this,
@@ skipping 46 matching lines @@
   bool waiting_;
   content::NotificationRegistrar registrar_;
   scoped_refptr<const Extension> extension_;
   scoped_refptr<const PermissionSet> permissions_;
   UpdatedExtensionPermissionsInfo::Reason reason_;
 };
 
 class PermissionsUpdaterTest : public ExtensionServiceTestBase {
 };
 
-scoped_refptr<Extension> LoadManifest(std::string* error) {
+scoped_refptr<Extension> LoadOurManifest() {
   base::FilePath path;
-  PathService::Get(chrome::DIR_TEST_DATA, &path);
-  path = path.AppendASCII("extensions")
-      .AppendASCII("api_test")
+  path = path.AppendASCII("api_test")
       .AppendASCII("permissions")
-      .AppendASCII("optional")
-      .AppendASCII("manifest.json");
-
-  JSONFileValueSerializer serializer(path);
-  scoped_ptr<Value> result(serializer.Deserialize(NULL, error));
-  if (!result)
-    return NULL;
-
-  scoped_refptr<Extension> extension = Extension::Create(
-      path.DirName(), Manifest::INTERNAL,
-      *static_cast<DictionaryValue*>(result.get()), Extension::NO_FLAGS, error);
-  return extension;
+      .AppendASCII("optional");
+#if defined(OS_WIN)

[Matt Perry, 2013/04/25 19:59:21]

Just use FilePath::AsUTF8Unsafe()

[vabr (Chromium), 2013/04/26 09:58:52]

Done.

+  // In this test, the paths are in ASCII anyway.
+  const std::string path_string(WideToASCII(path.value()));
+#else
+  const std::string& path_string(path.value());
+#endif
+  return LoadManifest(
+      path_string, "manifest.json", Manifest::INTERNAL, Extension::NO_FLAGS);
 }
 
 void AddPattern(URLPatternSet* extent, const std::string& pattern) {
   int schemes = URLPattern::SCHEME_ALL;
   extent->AddPattern(URLPattern(schemes, pattern));
 }
 
 }  // namespace
 
 // Test that the PermissionUpdater can correctly add and remove active
 // permissions. This tests all of PermissionsUpdater's public methods because
 // GrantActivePermissions and UpdateActivePermissions are used by
 // AddPermissions.
 TEST_F(PermissionsUpdaterTest, AddAndRemovePermissions) {
   InitializeEmptyExtensionService();
 
   // Load the test extension.
-  std::string error;
-  scoped_refptr<Extension> extension = LoadManifest(&error);
-  ASSERT_TRUE(error.empty()) << error;
+  scoped_refptr<Extension> extension = LoadOurManifest();
+  ASSERT_TRUE(extension.get());
 
   APIPermissionSet default_apis;
   default_apis.insert(APIPermission::kManagement);
   URLPatternSet default_hosts;
   AddPattern(&default_hosts, "http://a.com/*");
   scoped_refptr<PermissionSet> default_permissions =
       new PermissionSet(default_apis, default_hosts, URLPatternSet());
 
   // Make sure it loaded properly.
   scoped_refptr<const PermissionSet> permissions =
@@ skipping 64 matching lines @@
   // Verify that the extension prefs hold the new active permissions and the
   // same granted permissions.
   from_prefs = prefs->GetActivePermissions(extension->id());
   ASSERT_EQ(*active_permissions, *from_prefs);
 
   from_prefs = prefs->GetGrantedPermissions(extension->id());
   ASSERT_EQ(*granted_permissions, *from_prefs);
 }
 
 }  // namespace extensions