Almost all actions in Declarative Web Request require all_urls host permissions

chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 46 matching lines @@
   }
 
  protected:
   virtual ~TestWebRequestRulesRegistry() {}
 
   virtual base::Time GetExtensionInstallationTime(
       const std::string& extension_id) const OVERRIDE {
     if (extension_id == kExtensionId)
       return base::Time() + base::TimeDelta::FromDays(1);
     else if (extension_id == kExtensionId2)
       return base::Time() + base::TimeDelta::FromDays(2);

[vabr (Chromium), 2013/04/26 09:58:52]

The installation times are now set during SetUp when adding the extensions to
the extension info map.

     else
       return base::Time();
   }
 
   virtual void ClearCacheOnNavigation() OVERRIDE {
     ++num_clear_cache_calls_;
   }
 
  private:
   int num_clear_cache_calls_;
@@ skipping 537 matching lines @@
     SCOPED_TRACE(testing::Message("i = ") << i << ", rule id = "
                                           << matchingRuleIds[i]);
     // Make sure that the right rule succeeded.
     EXPECT_EQ(1u, matches.size());
     EXPECT_EQ(WebRequestRule::GlobalRuleId(std::make_pair(kExtensionId,
                                                           matchingRuleIds[i])),
               (*matches.begin())->id());
   }
 }
 
-TEST_F(WebRequestRulesRegistryTest, CheckConsistency) {
-  // The contentType condition can only be evaluated during ON_HEADERS_RECEIVED
-  // but the redirect action can only be executed during ON_BEFORE_REQUEST.
-  // Therefore, this is an inconsistent rule that needs to be flagged.
-  const char kRule[] =
-      "{                                                                 \n"
-      "  \"id\": \"rule1\",                                              \n"
-      "  \"conditions\": [                                               \n"
-      "    {                                                             \n"
-      "      \"instanceType\": \"declarativeWebRequest.RequestMatcher\", \n"
-      "      \"url\": {\"hostSuffix\": \"foo.com\"},                     \n"
-      "      \"contentType\": [\"image/jpeg\"]                           \n"
-      "    }                                                             \n"
-      "  ],                                                              \n"
-      "  \"actions\": [                                                  \n"
-      "    {                                                             \n"
-      "      \"instanceType\": \"declarativeWebRequest.RedirectRequest\",\n"
-      "      \"redirectUrl\": \"http://bar.com\"                         \n"
-      "    }                                                             \n"
-      "  ],                                                              \n"
-      "  \"priority\": 200                                               \n"
-      "}                                                                 ";
-
-  scoped_ptr<Value> value(base::JSONReader::Read(kRule));
-  ASSERT_TRUE(value.get());
-
-  std::vector<linked_ptr<RulesRegistry::Rule> > rules;
-  rules.push_back(make_linked_ptr(new RulesRegistry::Rule));
-  ASSERT_TRUE(RulesRegistry::Rule::Populate(*value, rules.back().get()));
-
-  scoped_refptr<WebRequestRulesRegistry> registry(
-      new TestWebRequestRulesRegistry());
-
-  URLMatcher matcher;
-  std::string error = registry->AddRulesImpl(kExtensionId, rules);
-  EXPECT_THAT(error, HasSubstr("no time in the request life-cycle"));
-  EXPECT_TRUE(registry->IsEmpty());
-}
-
 TEST_F(WebRequestRulesRegistryTest, CheckOriginAndPathRegEx) {
   const char kRule[] =
       "{                                                                 \n"
       "  \"id\": \"rule1\",                                              \n"
       "  \"conditions\": [                                               \n"
       "    {                                                             \n"
       "      \"instanceType\": \"declarativeWebRequest.RequestMatcher\", \n"
       "      \"url\": {\"originAndPathMatches\": \"fo+.com\"}            \n"
       "    }                                                             \n"
       "  ],                                                              \n"
@@ skipping 32 matching lines @@
 
   // This is a correct match.
   GURL url2("http://foo.com/index.html");
   net::TestURLRequest request2(url2, NULL, &context, NULL);
   WebRequestData request_data2(&request2, ON_BEFORE_REQUEST);
   deltas = registry->CreateDeltas(NULL, request_data2, false);
   EXPECT_EQ(1u, deltas.size());
 }
 
 }  // namespace extensions