Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1435793002: MIPS64: Fix after [turbofan] Avoid unnecessary write barriers and improve code generation. (Closed)

Created:
5 years, 1 month ago by paul.l...
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix after [turbofan] Avoid unnecessary write barriers and improve code generation. Use 64-bit add for address. TEST=mjsunit/sparse-array.js, others. BUG= Committed: https://crrev.com/6e0aa37c7e7a6a2271c2f0406206501691bd57ea Cr-Commit-Position: refs/heads/master@{#31937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL. Benedikt, could you please commit this as well? I suspect my usual reviewers are ...
5 years, 1 month ago (2015-11-11 06:19:19 UTC) #2
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-11-11 06:20:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435793002/1
5 years, 1 month ago (2015-11-11 06:20:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 06:38:29 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 06:38:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e0aa37c7e7a6a2271c2f0406206501691bd57ea
Cr-Commit-Position: refs/heads/master@{#31937}

Powered by Google App Engine
This is Rietveld 408576698