Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1435773002: Show form validation message as a fallback tooltip. (Closed)

Created:
5 years, 1 month ago by tkent
Modified:
5 years, 1 month ago
Reviewers:
keishi, kinuko
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show form validation message as a fallback tooltip. If a form control has no |title| content attribute, show a validation message as a tooltip. The new behavior is compatible with Firefox. BUG=550493 Committed: https://crrev.com/52dc0c9723271fa1949bd083b967ea91ddb32931 Cr-Commit-Position: refs/heads/master@{#359100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
tkent
keishi@, please review the whole change. kinuko@, please approve the content/test/ change.
5 years, 1 month ago (2015-11-11 04:20:23 UTC) #2
kinuko
lgtm for content change.
5 years, 1 month ago (2015-11-11 08:14:17 UTC) #4
keishi
LGTM
5 years, 1 month ago (2015-11-11 15:56:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435773002/1
5 years, 1 month ago (2015-11-11 16:07:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 16:40:33 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 19:57:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52dc0c9723271fa1949bd083b967ea91ddb32931
Cr-Commit-Position: refs/heads/master@{#359100}

Powered by Google App Engine
This is Rietveld 408576698