Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1435743003: X87: [turbofan] Avoid unnecessary write barriers and improve code generation. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Avoid unnecessary write barriers and improve code generation. port 1e2770123bd5c1cf7631bf11be846f0fbd884c08 (r31914) original commit message: Avoid write barriers when storing values in the root set, and use cheaper write barriers for storing maps or tagged pointers. Also improve the generated code for write barriers, utilizing the out of line code mechanism that is available to TurboFan backends, which moves the unlikely case out of the hot path. BUG= Committed: https://crrev.com/f1478bd141429a74b29029781de5784a5d561d33 Cr-Commit-Position: refs/heads/master@{#31935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -71 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 3 chunks +58 lines, -18 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +75 lines, -52 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-11 02:40:32 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-11 03:17:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435743003/1
5 years, 1 month ago (2015-11-11 03:17:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 03:37:45 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 03:38:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1478bd141429a74b29029781de5784a5d561d33
Cr-Commit-Position: refs/heads/master@{#31935}

Powered by Google App Engine
This is Rietveld 408576698