Fixing WebRtcBrowserTest.CallAndModifyStream, for new addStream behavior.

Fixing WebRtcBrowserTest.CallAndModifyStream, for new addStream behavior.

Soon, the peer connection will stop keeping track of modifications to an
added stream. So to add/remove tracks from a peer connection, you *must*
explicitly call addStream/removeStream.

Committed: https://crrev.com/4e956e25590dd29948add0df5d6dcadf5c0c7399
Cr-Commit-Position: refs/heads/master@{#359433}

[Taylor_Brandstetter, 2015-11-10 23:47:02]

deadbeef@chromium.org changed reviewers:
+ phoglund@chromium.org

[Taylor_Brandstetter, 2015-11-10 23:47:03]

phoglund@chromium.org: PTAL

The reasoning for this change is that addStream will soon be replaced by
addTrack (if you look at the latest draft of the W3C spec). Once we have
addTrack, addStream will just become a polyfill implemented with addTrack. And
thus it won't make sense for the PC to keep track of changes to the MediaStream
object.

[phoglund_chromium, 2015-11-11 07:56:42]

https://codereview.chromium.org/1435713002/diff/1/content/test/data/media/pee...
File content/test/data/media/peerconnection-call.html (right):

https://codereview.chromium.org/1435713002/diff/1/content/test/data/media/pee...
content/test/data/media/peerconnection-call.html:547:
gFirstConnection.removeStream(localStream);
So the idea is that you detach the stream, modify it, and re-add it? If you
don't re-add it, does that mean the tracks are added on a copy of the local
stream, but not the stream in the peer connection? 

Do we also need to modify enableLocalVideo etc, which also do modifications on
local streams?

[Taylor_Brandstetter, 2015-11-11 16:12:27]

https://codereview.chromium.org/1435713002/diff/1/content/test/data/media/pee...
File content/test/data/media/peerconnection-call.html (right):

https://codereview.chromium.org/1435713002/diff/1/content/test/data/media/pee...
content/test/data/media/peerconnection-call.html:547:
gFirstConnection.removeStream(localStream);
On 2015/11/11 07:56:42, phoglund_chrome wrote:
> So the idea is that you detach the stream, modify it, and re-add it? If you
> don't re-add it, does that mean the tracks are added on a copy of the local
> stream, but not the stream in the peer connection? 
> 
> Do we also need to modify enableLocalVideo etc, which also do modifications on
> local streams?

Yes, you have the right idea. And once we have addTrack/removeTrack, one could
just use those methods directly for finer control.

enableLocalVideo is fine, because we *will* still listen for changes to the
tracks. Just not changes to the contents of the stream.

[phoglund_chromium, 2015-11-12 07:51:14]

Okay, lgtm

[Taylor_Brandstetter, 2015-11-12 21:57:23]

The CQ bit was checked by deadbeef@chromium.org

[commit-bot: I haz the power, 2015-11-12 21:57:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435713002/1

[commit-bot: I haz the power, 2015-11-12 23:27:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-12 23:28:24]

Patchset 1 (id:??) landed as
https://crrev.com/4e956e25590dd29948add0df5d6dcadf5c0c7399
Cr-Commit-Position: refs/heads/master@{#359433}