Issue 1435673002: Clean up "magic" constants in QuicFramerTest to add comments which explains their values and extrac…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1435673002: Clean up "magic" constants in QuicFramerTest to add comments which explains their values and extrac… (Closed)

Created:
5 years, 1 month ago by rjshade

Modified:
5 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@107034442

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Clean up "magic" constants in QuicFramerTest to add comments which explains their values and extract out to named constants. Merge internal change: 107036345 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Use IPEndPoint #

Patch Set 3 : IPEndPoint #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -173 lines)			Patch
	M	net/quic/quic_framer_test.cc	View	1	73 chunks	+165 lines, -173 lines	0 comments	Download

Depends on Patchset:

Issue 1433783004 Patch 20001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages