content/renderer/service_worker/service_worker_context_client.cc - Issue 1435633002: Service Worker: Add FetchEvent.clientId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1435633002: Service Worker: Add FetchEvent.clientId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address the spec resolution: return null for navigation request Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/service_worker/service_worker_context_client.cc

diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc

index 7b0bd8964d5991fba14fa62fb519de9e7a3afbaf..60e067a56373f64a6f14042a98467946d80cccb4 100644

--- a/content/renderer/service_worker/service_worker_context_client.cc

+++ b/content/renderer/service_worker/service_worker_context_client.cc

@@ -733,12 +733,14 @@ void ServiceWorkerContextClient::OnFetchEvent(

blink::WebString::fromUTF8(request.referrer.url.spec()),

request.referrer.policy);

webRequest.setMode(GetBlinkFetchRequestMode(request.mode));

+ webRequest.setIsMainResourceLoad(request.is_main_resource_load);

webRequest.setCredentialsMode(

GetBlinkFetchCredentialsMode(request.credentials_mode));

webRequest.setRedirectMode(GetBlinkFetchRedirectMode(request.redirect_mode));

webRequest.setRequestContext(

GetBlinkRequestContext(request.request_context_type));

webRequest.setFrameType(GetBlinkFrameType(request.frame_type));

+ webRequest.setClientId(blink::WebString::fromUTF8(request.client_id));

webRequest.setIsReload(request.is_reload);

proxy_->dispatchFetchEvent(request_id, webRequest);

}