Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1435583002: Support spaces in output names in GN Linux (Closed)

Created:
5 years, 1 month ago by brettw
Modified:
5 years, 1 month ago
Reviewers:
Bons
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support spaces in output names in GN Linux This quotes BUILD-file-generated file names in command lines in the gcc_toolchain. I checked that executables and shared libraries with spaces can be built now. This doesn't affect Mac or Windows. BUG=546894 Committed: https://crrev.com/af7fb1f58f1d3348dab79312422f6c4bf5313101 Cr-Commit-Position: refs/heads/master@{#358708}

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 5 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
brettw
I did Linux since it was handier.
5 years, 1 month ago (2015-11-09 22:32:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435583002/1
5 years, 1 month ago (2015-11-09 22:34:21 UTC) #5
Bons
lgtm
5 years, 1 month ago (2015-11-09 22:34:33 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/92041) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-09 22:37:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435583002/20001
5 years, 1 month ago (2015-11-09 22:56:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-09 23:56:28 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 23:57:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af7fb1f58f1d3348dab79312422f6c4bf5313101
Cr-Commit-Position: refs/heads/master@{#358708}

Powered by Google App Engine
This is Rietveld 408576698