Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: runtime/vm/object.h

Issue 1435533003: Make profiler work without Instructions -> Code pointer (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 5b2beafd917a68348092b40a863985287600f6f3..69bd6f448dc0ae451f8be66260097168035c61c4 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -3741,13 +3741,6 @@ class Instructions : public Object {
public:
intptr_t size() const { return raw_ptr()->size_; } // Excludes HeaderSize().
- RawCode* code() const {
- // This should only be accessed when jitting.
- // TODO(johnmccutchan): Remove code back pointer.
- ASSERT(!Dart::IsRunningPrecompiledCode());
- return raw_ptr()->code_;
- }
-
uword EntryPoint() const {
return reinterpret_cast<uword>(raw_ptr()) + HeaderSize();
}
@@ -3786,10 +3779,6 @@ class Instructions : public Object {
StoreNonPointer(&raw_ptr()->size_, size);
}
- void set_code(RawCode* code) const {
- StorePointer(&raw_ptr()->code_, code);
- }
-
// New is a private method as RawInstruction and RawCode objects should
// only be created using the Code::FinalizeCode method. This method creates
// the RawInstruction and RawCode objects, sets up the pointer offsets
@@ -4422,22 +4411,6 @@ class Code : public Object {
class AliveBit : public BitField<bool, kAliveBit, 1> {};
class PtrOffBits : public BitField<intptr_t, kPtrOffBit, kPtrOffSize> {};
- // An object finder visitor interface.
- class FindRawCodeVisitor : public FindObjectVisitor {
- public:
- explicit FindRawCodeVisitor(uword pc)
- : FindObjectVisitor(Isolate::Current()), pc_(pc) { }
- virtual ~FindRawCodeVisitor() { }
-
- // Check if object matches find condition.
- virtual bool FindObject(RawObject* obj) const;
-
- private:
- const uword pc_;
-
- DISALLOW_COPY_AND_ASSIGN(FindRawCodeVisitor);
- };
-
class SlowFindRawCodeVisitor : public FindObjectVisitor {
public:
explicit SlowFindRawCodeVisitor(uword pc)
« no previous file with comments | « runtime/vm/heap.h ('k') | runtime/vm/object.cc » ('j') | runtime/vm/profiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698