Make profiler work without Instructions -> Code pointer

Make profiler work without Instructions -> Code pointer

- Do one eager pass over both the vm and current isolate's heaps to populate the live code table instead of lazily sampling the heap for code objects.
- Remove Instructions -> Code pointer

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/f5e63ba792163d0c09bcf87f97563e5da305c65d

[Cutch, 2015-11-09 20:41:31]

Description was changed from

==========
Remove Instructions -> Code pointer

BUG=
==========

to

==========
Remove Instructions -> Code pointer

- Do one eager pass over both the vm and current isolate's heaps to populate the
live code table instead of lazily sampling the heap for code objects.
==========

[Cutch, 2015-11-10 15:36:21]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2015-11-10 15:36:59]

Description was changed from

==========
Remove Instructions -> Code pointer

- Do one eager pass over both the vm and current isolate's heaps to populate the
live code table instead of lazily sampling the heap for code objects.
==========

to

==========
Make profiler work without Instructions -> Code pointer

- Do one eager pass over both the vm and current isolate's heaps to populate the
live code table instead of lazily sampling the heap for code objects.
- Remove Instructions -> Code pointer
==========

[rmacnak, 2015-11-10 18:53:13]

Also undo https://codereview.chromium.org//1375283003

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:1135: ASSERT(FindCode(0) == NULL);
This can go out of the loop

[srdjan, 2015-11-10 19:08:50]

srdjan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-11-10 19:08:51]

DBC

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:1054: : code_(code) {
One line

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:1154: // std::upper_bound.
Why this comment?

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:1162: if (!(pc < cd->Entry())) {
Either pc >= cd->Entry() or

if (pc<cd->Entry()) {
  count = step
} else {
 ...
{

[Cutch, 2015-11-10 19:12:21]

PTAL

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:1054: : code_(code) {
On 2015/11/10 19:08:51, srdjan wrote:
> One line

Done.

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:1135: ASSERT(FindCode(0) == NULL);
On 2015/11/10 18:53:13, rmacnak wrote:
> This can go out of the loop

Done.

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:1154: // std::upper_bound.
On 2015/11/10 19:08:51, srdjan wrote:
> Why this comment?

It's the name of the algorithm from C++ <algorithms> header. It's unnecessary-
Removed.

https://codereview.chromium.org/1435533003/diff/20001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:1162: if (!(pc < cd->Entry())) {
On 2015/11/10 19:08:51, srdjan wrote:
> Either pc >= cd->Entry() or
> 
> if (pc<cd->Entry()) {
>   count = step
> } else {
>  ...
> {

Done.

[rmacnak, 2015-11-10 19:19:36]

lgtm

[Cutch, 2015-11-10 19:33:57]

Committed patchset #6 (id:100001) manually as
f5e63ba792163d0c09bcf87f97563e5da305c65d (presubmit successful).