Issue 1435523002: Refactor mojo_benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1435523002: Refactor mojo_benchmark. (Closed)

Created:
5 years, 1 month ago by ppi

Modified:
5 years, 1 month ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Refactor mojo_benchmark. This patch extract the logic that interacts with the mojo benchmark app from `mojo_benchmark` into devtoolslib and adds some tests. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0a40516baad86d171958347cd2bb95199b287110

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -94 lines)			Patch
A	mojo/devtools/common/devtoolslib/benchmark.py	View		1 chunk	+103 lines, -0 lines	0 comments	Download
A	mojo/devtools/common/devtoolslib/benchmark_unittest.py	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
M	mojo/devtools/common/mojo_benchmark	View		7 chunks	+10 lines, -94 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

5 years, 1 month ago (2015-11-09 16:02:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
0a40516baad86d171958347cd2bb95199b287110 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages