Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: mojo/devtools/common/mojo_benchmark

Issue 1435493003: Only upload non-empty packets to performance dashboard. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/mojo_benchmark
diff --git a/mojo/devtools/common/mojo_benchmark b/mojo/devtools/common/mojo_benchmark
index ec17ad0fc52a1fbce22f015f430614e1ff4f9dfd..6ade1b14f17a7ba7b4fbe45b3a7ee743c43a2acd 100755
--- a/mojo/devtools/common/mojo_benchmark
+++ b/mojo/devtools/common/mojo_benchmark
@@ -197,6 +197,7 @@ def main():
print '[ %s ] %s ' % (benchmark_name, variant_name)
some_measurements_failed = False
+ some_measurements_succeeded = False
if benchmark_succeeded:
measurement_results = _parse_measurement_results(output)
# Iterate over the list of specs, not the dictionary, to detect missing
@@ -212,6 +213,7 @@ def main():
perf_dashboard.normalize_label(chart_name),
perf_dashboard.normalize_label(measurement['name']),
'ms', result)
+ some_measurements_succeeded = True
else:
print '? %s' % measurement['name']
some_measurements_failed = True
@@ -227,7 +229,7 @@ def main():
print '-' * 72
exit_code = 1
- if script_args.upload:
+ if script_args.upload and some_measurements_succeeded:
if not perf_dashboard.upload_chart_data(
script_args.master_name, script_args.bot_name,
script_args.test_name, script_args.builder_name,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698