Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14354004: Revert 194775 "Modify AccessibilityTreeFormatter to build up an ..." (Closed)

Created:
7 years, 8 months ago by kjellander_chromium
Modified:
7 years, 8 months ago
Reviewers:
aboxhall
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194775 "Modify AccessibilityTreeFormatter to build up an ..." > Modify AccessibilityTreeFormatter to build up an internal representation of the tree in the form of DictionaryValue et al. This may be used at a later stage to create a JSON representation of the tree. > > Also modify the Mac platform implementation to use the NSAccessibility attribute names rather than method names. > > BUG= > > Review URL: https://chromiumcodereview.appspot.com/13479003 TBR=aboxhall@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -686 lines) Patch
M trunk/src/content/browser/accessibility/accessibility_tree_formatter.h View 3 chunks +8 lines, -51 lines 0 comments Download
M trunk/src/content/browser/accessibility/accessibility_tree_formatter.cc View 4 chunks +27 lines, -63 lines 0 comments Download
M trunk/src/content/browser/accessibility/accessibility_tree_formatter_mac.mm View 2 chunks +87 lines, -131 lines 0 comments Download
M trunk/src/content/browser/accessibility/accessibility_tree_formatter_win.cc View 2 chunks +74 lines, -197 lines 0 comments Download
M trunk/src/content/test/data/accessibility/a-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/a-with-img.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/a-with-img-expected-mac.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M trunk/src/content/test/data/accessibility/address.html View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/address-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-application.html View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-application-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/aria-combobox-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-invalid.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/aria-invalid-expected-mac.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-level.html View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-level-expected-mac.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-menu.html View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-menu-expected-mac.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-menuitemradio.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/aria-menuitemradio-expected-mac.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-pressed-expected-mac.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-progressbar.html View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-progressbar-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-valuemax.html View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-valuemax-expected-mac.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-valuemin.html View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/aria-valuemin-expected-mac.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/content/test/data/accessibility/article.html View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/article-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/bdo.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/bdo-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/br-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/button-name-calc.html View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/button-name-calc-expected-mac.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M trunk/src/content/test/data/accessibility/canvas-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/checkbox-name-calc.html View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/checkbox-name-calc-expected-mac.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M trunk/src/content/test/data/accessibility/div-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/dl.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/dl-expected-mac.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M trunk/src/content/test/data/accessibility/em-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/footer.html View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/footer-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/form-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/heading-expected-mac.txt View 1 chunk +24 lines, -24 lines 0 comments Download
M trunk/src/content/test/data/accessibility/iframe-coordinates.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + trunk/src/content/test/data/accessibility/iframe-coordinates-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/test/data/accessibility/input-button.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/input-button-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/input-color.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/input-color-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/input-range-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/label-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/list-markers.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/list-markers-expected-mac.txt View 1 chunk +13 lines, -13 lines 0 comments Download
M trunk/src/content/test/data/accessibility/p-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/select.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/select-expected-mac.txt View 1 chunk +17 lines, -17 lines 0 comments Download
M trunk/src/content/test/data/accessibility/span.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/span-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/spinbutton.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/spinbutton-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/svg.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/svg-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/tab-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/togglebutton-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/test/data/accessibility/toolbar.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/toolbar-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/ul.html View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/data/accessibility/ul-expected-mac.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M trunk/src/content/test/data/accessibility/wbr-expected-mac.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kjellander_chromium
7 years, 8 months ago (2013-04-18 12:21:19 UTC) #1
kjellander_chromium
7 years, 8 months ago (2013-04-18 12:21:47 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r194895.

Powered by Google App Engine
This is Rietveld 408576698