Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Side by Side Diff: src/arm/lithium-codegen-arm.h

Issue 14354003: HArgument instructions currently require a frame. In Lithium we can ensure a frame (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/compiler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 MacroAssembler* masm() const { return masm_; } 74 MacroAssembler* masm() const { return masm_; }
75 CompilationInfo* info() const { return info_; } 75 CompilationInfo* info() const { return info_; }
76 Isolate* isolate() const { return info_->isolate(); } 76 Isolate* isolate() const { return info_->isolate(); }
77 Factory* factory() const { return isolate()->factory(); } 77 Factory* factory() const { return isolate()->factory(); }
78 Heap* heap() const { return isolate()->heap(); } 78 Heap* heap() const { return isolate()->heap(); }
79 Zone* zone() const { return zone_; } 79 Zone* zone() const { return zone_; }
80 80
81 bool NeedsEagerFrame() const { 81 bool NeedsEagerFrame() const {
82 return GetStackSlotCount() > 0 || 82 return GetStackSlotCount() > 0 ||
83 info()->is_non_deferred_calling() || 83 info()->is_non_deferred_calling() ||
84 !info()->IsStub(); 84 !info()->IsStub() ||
85 info()->requires_frame();
85 } 86 }
86 bool NeedsDeferredFrame() const { 87 bool NeedsDeferredFrame() const {
87 return !NeedsEagerFrame() && info()->is_deferred_calling(); 88 return !NeedsEagerFrame() && info()->is_deferred_calling();
88 } 89 }
89 90
90 LinkRegisterStatus GetLinkRegisterState() const { 91 LinkRegisterStatus GetLinkRegisterState() const {
91 return frame_is_built_ ? kLRHasBeenSaved : kLRHasNotBeenSaved; 92 return frame_is_built_ ? kLRHasBeenSaved : kLRHasNotBeenSaved;
92 } 93 }
93 94
94 // Support for converting LOperands to assembler types. 95 // Support for converting LOperands to assembler types.
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 LCodeGen* codegen_; 498 LCodeGen* codegen_;
498 Label entry_; 499 Label entry_;
499 Label exit_; 500 Label exit_;
500 Label* external_exit_; 501 Label* external_exit_;
501 int instruction_index_; 502 int instruction_index_;
502 }; 503 };
503 504
504 } } // namespace v8::internal 505 } } // namespace v8::internal
505 506
506 #endif // V8_ARM_LITHIUM_CODEGEN_ARM_H_ 507 #endif // V8_ARM_LITHIUM_CODEGEN_ARM_H_
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698