Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 1435373002: [turbofan] Don't abort inlining on first failed attempt. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't abort inlining on first failed attempt. Continue with the other candidates in case of a failed attempt to inline a certain candidate. TBR=mstarzinger@chromium.org BUG=v8:4493 LOG=n Committed: https://crrev.com/47396c414209661ef8e11e35085ab5b2acbfe3c3 Cr-Commit-Position: refs/heads/master@{#31975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M src/compiler/js-inlining-heuristic.cc View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Benedikt Meurer
Hey Michi, The heuristic now aborts too early :-( Hopefully this will be the last ...
5 years, 1 month ago (2015-11-12 19:45:54 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435373002/1
5 years, 1 month ago (2015-11-12 20:01:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 20:26:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435373002/1
5 years, 1 month ago (2015-11-13 04:47:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 04:50:50 UTC) #11
Michael Starzinger
LGTM.
5 years, 1 month ago (2015-11-13 08:54:24 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47396c414209661ef8e11e35085ab5b2acbfe3c3
Cr-Commit-Position: refs/heads/master@{#31975}

Powered by Google App Engine
This is Rietveld 408576698